Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datepicker customizable #72

Closed
ghetolay opened this issue Oct 10, 2016 · 4 comments
Closed

Make datepicker customizable #72

ghetolay opened this issue Oct 10, 2016 · 4 comments

Comments

@ghetolay
Copy link

Hi,

Datepicker is complicated ui element because everybody wants to render it differently. You just have to look at all the implementations available. For me none fits, I would need a mix of different approach. We could just take your issue #52 about year control, some does not need it, some wants double arrow and I'm more for a dropdown menu.

With angular 2 and ng-content I think we should be able to create a component flexible enough to cover all needs. I'm thinking about a DatePickerCore with a good API to be manipulated, a minimal static template and using multiple <ng-content> for the rest of the template. Then we could create some of the most common datepicker on top of that core (DatePickerMinimal, DatePickerFull) and for uncommon users like me, they could still create their own component based on DatePickerCore.

I could start working on yet another datepicker plugin but, if you are up to it, I would rather rally with you so we could build a good and flexible datepicker plugin for once.

@jkuri
Copy link
Contributor

jkuri commented Oct 10, 2016

@ghetolay that sounds like a perfect idea, really. unfortunately I am really busy lately, but if you are prepared to contribute on this one I can add you to the repo and you develop this on a separate branch. that would be awesome.

@ghetolay
Copy link
Author

@jkuri Yep no problem let's do it.

How should we proceed to discuss about specs ? Is opening issues ok ?

@jkuri
Copy link
Contributor

jkuri commented Oct 10, 2016

yes, that should be fine I think

@ghetolay
Copy link
Author

Closed in favor of #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants