Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/recover doesn't work for programs that require a TTY / stdin #139

Open
dhermes opened this issue Nov 9, 2019 · 0 comments
Open

cmd/recover doesn't work for programs that require a TTY / stdin #139

dhermes opened this issue Nov 9, 2019 · 0 comments
Labels
v3.x.y Version 3 series

Comments

@dhermes
Copy link
Contributor

dhermes commented Nov 9, 2019

What happened:

$ go build -o main cmd/recover/main.go
$ ./main -verbose python
recover: "python" resolved to "/Users/dhermes/.pyenv/shims/python"
^Crecover: received SIGINT (interrupt) while sub process is running, killing sub process
recover: sub process exit: signal: interrupt

What you expected to happen:

$ ./main -verbose python
recover: "python" resolved to "/Users/dhermes/.pyenv/shims/python"
Python 3.7.3 (default, Mar 27 2019, 08:18:46) 
[Clang 10.0.1 (clang-1001.0.46.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> 
...

How to reproduce it (as minimally and precisely as possible):

See above

Anything else we need to know?:

This is not urgent or even necessarily a feature, but we could early exit if we detect TTY / stdin is needed.

Environment:

@dhermes dhermes added the v3.x.y Version 3 series label Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.x.y Version 3 series
Projects
None yet
Development

No branches or pull requests

1 participant