Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span type and span operation name for oauthtrace are generic HTTP #163

Open
dhermes opened this issue Jan 15, 2020 · 0 comments
Open

Span type and span operation name for oauthtrace are generic HTTP #163

dhermes opened this issue Jan 15, 2020 · 0 comments
Assignees
Labels
v3.x.y Version 3 series

Comments

@dhermes
Copy link
Contributor

dhermes commented Jan 15, 2020

See

opentracing.Tag{Key: tracing.TagKeySpanType, Value: tracing.SpanTypeHTTP},
opentracing.StartTime(time.Now().UTC()),
}
span, _ := tracing.StartSpanFromContext(ctx, t.tracer, tracing.OperationHTTPRequest, startOptions...)

The span.type=http tag and operationName=http.request in the StartSpanFromContext() don't seem specific enough to OAuth.

The OperationHTTPRequest is used in stats/tracing/oauthtrace, stats/tracing/r2trace and stats/tracing/webtrace (as of e7d08d5) and SpanTypeHTTP is used in stats/tracing/oauthtrace and stats/tracing/r2trace.

@dhermes dhermes added the v3.x.y Version 3 series label Jan 15, 2020
@dhermes dhermes self-assigned this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.x.y Version 3 series
Projects
None yet
Development

No branches or pull requests

1 participant