Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-by-one error in line numbers in panic output from within a goroutine #194

Open
dhermes opened this issue Apr 10, 2020 · 0 comments
Open

Off-by-one error in line numbers in panic output from within a goroutine #194

dhermes opened this issue Apr 10, 2020 · 0 comments
Assignees
@dhermes
Labels
v3.x.y Version 3 series

Comments

@dhermes
Copy link
Contributor

dhermes commented Apr 10, 2020

May be related to: golang/go#34123 (comment)

I still need to reproduce this in a "minimal" and "open" fashion but we had an internal file where line 43 caused a panic in a goroutine but the stack referred to line 42.
@dhermes dhermes added the v3.x.y Version 3 series label Apr 10, 2020
@dhermes dhermes self-assigned this Apr 10, 2020
@dhermes dhermes changed the title Off-by-one error in lines in panic output from within a goroutine Off-by-one error in line numbers in panic output from within a goroutine Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
v3.x.y Version 3 series
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhermes