Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the network volume #1

Closed
TimPietrusky opened this issue Oct 11, 2023 · 6 comments · Fixed by #35
Closed

Add support for the network volume #1

TimPietrusky opened this issue Oct 11, 2023 · 6 comments · Fixed by #35
Labels
enhancement New feature or request released

Comments

@TimPietrusky
Copy link
Member

TimPietrusky commented Oct 11, 2023 •
edited
Loading

In order to let the user add custom things (like models / LoRA / nodes) into Comfy without changing the actual docker image, we could leverage a network volume.
@TimPietrusky TimPietrusky added the enhancement New feature or request label Oct 13, 2023
@TimPietrusky TimPietrusky mentioned this issue Oct 13, 2023
Closed
@kenster4000
Copy link

yes please :)

@TimPietrusky
Copy link
Member Author

This will propably come next week as we also need this feature!

@ardha27
Copy link

ardha27 commented Nov 16, 2023

is this already implemented?

This will propably come next week as we also need this feature!

@TimPietrusky
Copy link
Member Author

TimPietrusky commented Nov 17, 2023 •
edited
Loading

@ardha27 sadly, we had a change in plans and couldn't implement it yet. But we want to do this, we just can't promise a deadline.

Overall, this feature is not very complicated, it's mostly split into to parts:

  1. Configure the network volume on RunPod and how to prepare it to be used with runpod-worker-comfy
  2. Mount the network volume into the container, so that the network-volume is used instead of the folders in ComfyUI

@Meptl Meptl mentioned this issue Dec 19, 2023
Merged
@TimPietrusky TimPietrusky mentioned this issue May 29, 2024
Merged
@TimPietrusky
Copy link
Member Author

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@TimPietrusky
Copy link
Member Author

@kenster4000 @ardha27 support for network-volumes is finally merged!

Thanks to @Meptl for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
3 participants
@TimPietrusky @kenster4000 @ardha27