Bug: PULL-PUSH-PULL 1D Column vector will convert into 1D Row Vector

[yasirroni]

This is working just fine:

m.eval("x = cell(1,4); x(:) = 1.0;")
x = m.pull('x')
x
# (Cell([[1.0, 1.0, 1.0, 1.0]]), (1, 4))
m.push('x', x)
x = m.pull('x')
x
# (Cell([[1.0, 1.0, 1.0, 1.0]]), (1, 4))

But, this will convert into (1,n)

m.eval("x = cell(4,1); x(:) = 1.0;")
x = m.pull('x')
x
# (Cell([1.0, 1.0, 1.0, 1.0]), (4,))
m.push('x', x)
x = m.pull('x')
x
# (Cell([1.0, 1.0, 1.0, 1.0]), (1,4))

[yasirroni]

After investigating, the problem located on m.push()

m.eval("x = cell(4,1); x(:) = 1.0;")
m.eval('size(x)')

# ans =

#    4   1

x = m.pull('x')
print(np.shape(x))

# (4,)

m.push('x', x)
m.eval('size(x)')

# ans =

#    1   4

[yasirroni]

A fix would be force 1D Cell push as 2D Cell push or fix it while octave reading (the latter is better)

---

Edit:

If we look at how m.eval('size(x)') return (4,1), I think we should also use numpy atleast 2D?

x = m.pull('x')
print(np.shape(x))

# (4,)

[yasirroni]

Should we change it to atleast 2D or add special case for Column vector?

oct2py/oct2py/io.py

Lines 224 to 226 in e8ebd99

	if (value.shape[value.ndim - 1] == 1):
	value = value.squeeze(axis=value.ndim - 1)
	value = np.atleast_1d(value)

[blink1073]

I think special casing Column vector makes sense.

Adding a few tests that ensure we preserve the shape for (n,1) and (1,n) cells would help as well.

We should be able to round trip these cells without losing the shape, that was an oversight on my part.