Limit performance increase + Bugfix for many
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug that caused indexed entries to not be deleted correctly from the index
Fix a bug with `many` not returning any items if options are specified but no `where` is defined
✅ Deploy Preview for blinkdb canceled.
|
Valerionn
changed the title
many
|
Performance increases on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #3 for additional benchmarking (therefore this PR contains the other changes as well until it's merged).
I have changed
limitItemsto need way less array operations when limiting/paginating a large item data set.I also fixed a bug with
manywhich didn't return any items if filter options are defined but don't contain awhere(e.g. when paginating the whole data set).many query with limit:
Before
After