Ability to access the session data within a passport strategy

[james2406]

What do you want and why?

I would like to be able to access the session data inside the verify callback of the passport strategy.

This session data is set on an anonymous session via the ctx.session.$setPublicData() and ctx.session.$setPrivateData() functions.

Possible implementation(s)

Potentially, the passportAuth function could accept a callback which would provide the ctx.session, like so:

export default passportAuth((ctx) => ({
  successRedirectUrl: "/",
  errorRedirectUrl: "/",
  strategies: [
    {
      strategy: new TwitterStrategy(
        {
          consumerKey: process.env.TWITTER_CONSUMER_KEY,
          //...
        },
        async function (_token, _tokenSecret, profile, done) {
          const email = profile.emails && profile.emails[0]?.value

          // WANT: access ctx.session.publicData here
 
          const user = await db.user.upsert({
            where: {email},
            create: {
              email,
              name: profile.displayName,
            },
            update: {email},
          })

          const publicData = {/* ... */}
          done(null, {publicData})
        },
      ),
    },
    },
  ],
}))

[flybayer]

Sweet, thanks! Great idea.

This change needs to be made in the passport-adapter.ts file. We'll need to run global middleware at start of function instead of the end, we can access ctx.

So something like this:

+   // First run global middleware so we can access session
+   const globalMiddleware = getAllMiddlewareForModule({} as any)
+   await handleRequestWithMiddleware(req, res, globalMiddleware)

+   // pseudo code: if passportAuth config is callback, call it with `res.blitzCtx` as argument
 
    // rest of passport code

-    const globalMiddleware = getAllMiddlewareForModule({} as any)
-    await handleRequestWithMiddleware(req, res, [...globalMiddleware, ...middleware])
+    // Now only run the specific passport middleware that we constructed
+    await handleRequestWithMiddleware(req, res, middleware)

[james2406]

Okay. This makes a lot of sense! I'm happy to take a go at this change and submit a PR.