Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superjson.registerCustom is not defined when "type": "module" (regression) #214

Closed
mgreystone opened this issue Dec 13, 2022 · 3 comments · Fixed by #215
Closed

superjson.registerCustom is not defined when "type": "module" (regression) #214

mgreystone opened this issue Dec 13, 2022 · 3 comments · Fixed by #215

Comments

@mgreystone
Copy link

It appears #186 has been re-introduced in v1.11.0.

If i have "type": "module" set in package.json, then superjson.registerCustom does not exist. superjson.default.registerCustom exists, but typescript cannot find it.

v1.10.1 works as expected.
@Skn0tt Skn0tt mentioned this issue Dec 19, 2022
Merged
@Skn0tt
Copy link
Member

Skn0tt commented Dec 19, 2022

Should be fixed in https://github.com/blitz-js/superjson/releases/tag/v1.12.1. Thank you for reporting!

@all-contributors please add @mgreystone for bug

@allcontributors allcontributors bot mentioned this issue Dec 19, 2022
Merged
@allcontributors
Copy link
Contributor

@Skn0tt

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @mgreystone! 🎉

@mgreystone
Copy link
Author

Confirmed fixed on my end. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: export statics as named exports blitz-js/superjson
2 participants
@mgreystone @Skn0tt