Implemented hummingbird.me and reworked code slightly to allow more flexibility for providers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customized code a bit to allow for custom parsing from provider (regex doesn't work for hummingbird because the page depends on javascript to load so API must be used)
|
Hi, thank you for the pull request! |
akyoto
added a commit
that referenced
this pull request
Oct 14, 2014
Implemented hummingbird.me and reworked code slightly to allow more flexibility for providers
|
I tested it and it works, thank you very much for your help! |
akyoto
pushed a commit
that referenced
this pull request
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites, like hummingbird.me, rely heavily on javascript to deliver the anime list content making it impossible to get the content with a simple http request. Fortunately hummingbird.me has a JSON API which I made use of instead.
The major changes I made are:
beforSendfunction to anime-list-provider, called before sending anime list requestoverrideParsefunction to allow custom/non-regex parsing of anime listsapiUrlandapiUrlSuffixused only to retrieve anime list and not displayed to user in popupresponseTypefor anime list request (defaulting totext) for a consistency withbeforeSendNote: In the hummingbird provider I send a header with an API key I generated on mashape.
I recognize that this isn't a beautiful fix but I made it for myself and I figured I might as well share in case it can be of use to the main project. Perhaps a more complete reworking of the provider processing code is in order to better handle cases like these.