Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.MFSwitchPercent > 0 not working anymore in restructure branch #396

Closed
curry2810 opened this issue Jan 4, 2024 · 0 comments · May be fixed by #380
Closed

Config.MFSwitchPercent > 0 not working anymore in restructure branch #396

curry2810 opened this issue Jan 4, 2024 · 0 comments · May be fixed by #380

Comments

@curry2810
Copy link

If I for example set Config.MFSwitchPercent = 20 in character config file, the bot will not switch to secondary weapon slot if boss health drops below 20%. It will just stick to primary weapon slot.

I tried with both Config.PrimarySlot = -1 and Config.PrimarySlot = 0, as I was not sure if the setting is affected by the line above. It didnt make any difference though.

As the following line in Attack.js didnt make any sense for me (why switch to primary if you want to switch to secondary?):

Config.MFSwitchPercent && target.hpPercent < Config.MFSwitchPercent && me.switchToPrimary();

I modified it to

Config.MFSwitchPercent && target.hpPercent < Config.MFSwitchPercent && me.switchWeapons(1);

Now it seems to be working fine.

@theBGuy theBGuy linked a pull request Mar 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant