Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled TextInput fixes #10

Closed
wants to merge 1 commit into from
Closed

Disabled TextInput fixes #10

wants to merge 1 commit into from

Conversation

hovatterz
Copy link
Contributor

@hovatterz hovatterz commented Jan 3, 2021

When disabled a text input will no longer respond to delete/movement commands

When disabled a text input will no longer respond to delete/movement
commands

When disabled a text input will no longer render the carat when focused
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blizzy78
Copy link
Contributor

blizzy78 commented Jan 4, 2021

This is actually the intended behavior: For text inputs, "disabled" only means "read-only." You are still supposed to position the cursor, and (eventually) select and copy text.

Also see my comment here: #9 (comment)

@blizzy78 blizzy78 added the bug Something isn't working label Jan 4, 2021
@hovatterz
Copy link
Contributor Author

Gotcha! My repo was out of date apparently :)

@hovatterz hovatterz closed this Jan 4, 2021
@hovatterz hovatterz deleted the fix-disabled-text-inputs branch January 4, 2021 00:24
@blizzy78 blizzy78 added the invalid This doesn't seem right label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Development

Successfully merging this pull request may close these issues.

None yet

2 participants