Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errata when changing resolutions during startup #11

Closed
Blobanium opened this issue Mar 7, 2021 · 7 comments
Closed

Errata when changing resolutions during startup #11

Blobanium opened this issue Mar 7, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@Blobanium
Copy link
Owner

Blobanium commented Mar 7, 2021 •
edited
Loading

Extended From #9 as another issue was discovered
@Blobanium Blobanium added the bug Something isn't working label Mar 7, 2021
@Blobanium Blobanium mentioned this issue Mar 7, 2021
Closed
@Blobanium Blobanium changed the title Errata with the fullscreen Safeguard while doing certain actions Errata when changing resolutions Mar 7, 2021
@Blobanium Blobanium changed the title Errata when changing resolutions Errata when changing resolutions during startup Mar 7, 2021
@Blobanium Blobanium added this to the Version 1.2.2 milestone Mar 7, 2021
@Blobanium
Copy link
Owner Author

i probably removed the safeguard entirely bc it pretty much didn't work well. safe to close.

@K0-RR
Copy link
Contributor

K0-RR commented Apr 10, 2021

So, what about this issue?
image

@Blobanium
Copy link
Owner Author

Blobanium commented Apr 10, 2021 •
edited
Loading

is this the latest version of the mod?

@K0-RR
Copy link
Contributor

K0-RR commented Apr 10, 2021

Yes, 1.3-Beta1

@Blobanium
Copy link
Owner Author

Blobanium commented Apr 10, 2021 •
edited
Loading

reopening this as this seems to be a confirmed bug. ill look into this.

@Blobanium Blobanium reopened this Apr 10, 2021
@Blobanium Blobanium removed this from the Version 1.2.2 milestone Apr 10, 2021
Blobanium added a commit that referenced this issue Apr 11, 2021
@Blobanium
Implement a workaround for #11
375d47a 
this should work
@Blobanium
Copy link
Owner Author

Blobanium commented Apr 11, 2021 •
edited
Loading

i tested the workaround myself and the bug should be fixed. I also made it so that would log an error saying to refrain from changing resolutions during startup. (id probably want to change this to log a warn instead of an error)

@Blobanium
Copy link
Owner Author

anyways closing this thread (again) as the bug seems to be fixed, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@K0-RR @Blobanium