Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser opening leaves url bar empty if the internal url is invalid #4

Closed
HiWord9 opened this issue Nov 7, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@HiWord9
Copy link
Contributor

HiWord9 commented Nov 7, 2023

If browser was opened internaly on invalid url, the url bar becomes empty.
It can be reproduced by changing the default page to invalid url.
2023-11-07_04 19 19
2023-11-07_04 19 32

I found it while i was creating my pull request #3 in which i added ability to open browser with non-default page by command.
Firstly i thought it was bug that i've created, but then i've tested it the way i mentioned earlyer and got sure i had not.

@Blobanium Blobanium added the bug Something isn't working label Nov 7, 2023
HiWord9 added a commit to HiWord9/MCBrowser that referenced this issue Nov 8, 2023
@HiWord9
Copy link
Contributor Author

HiWord9 commented Nov 8, 2023

commit 1e345d9 does not solves the problem, the bug is still here. The problem is somewhere on calling BrowserScreen, not on which request u give to it. When u type incorrect url in urlBox it firstly tryes to reach it, and after fail sets the urlBox to what u've been writing to it. So the thing where it sets text to urlBox does not calls on entering incorrect url manually, not by typing it by keuboard.

Blobanium added a commit that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants