Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RadiusNeighborsClassifier #51

Merged

Conversation

aadityasinha-dotcom
Copy link
Contributor

Issue Id you have worked upon -

#48

CHANGES MADE -

Added RadiusNeighborsClassifier.

Made changes to -

"https://github.com/blobcity/autoai/blob/main/blobcity/config/classifier_config.py"

NOTE -

Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label to it.

@Thilakraj1998
Copy link
Contributor

radius neighbor Classifier doesnt have n_neighbors has a parameter:

do refer offical documentation for parameters: https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.RadiusNeighborsClassifier.html

@aadityasinha-dotcom
Copy link
Contributor Author

radius neighbor Classifier doesnt have n_neighbors has a parameter:

do refer offical documentation for parameters: https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.RadiusNeighborsClassifier.html

Okay, I will recheck that.

@aadityasinha-dotcom
Copy link
Contributor Author

aadityasinha-dotcom commented Oct 5, 2021

@Thilakraj1998 I have removed n_neighbors. Is there any changes left that I have missed?

@Thilakraj1998
Copy link
Contributor

@aadityasinha-dotcom

it still missing some of the parameter configuration like radius, metric and outlier_label

@aadityasinha-dotcom
Copy link
Contributor Author

@Thilakraj1998 It was only missing the radius parameter, I have added that. Is there anything else?

@Thilakraj1998
Copy link
Contributor

@aadityasinha-dotcom for metric parameter there are more then 1 distance metric

do consider consider adding following distance metrics mentioned in the official documentation:
https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.DistanceMetric.html#sklearn.neighbors.DistanceMetric

@aadityasinha-dotcom
Copy link
Contributor Author

aadityasinha-dotcom commented Oct 7, 2021

@aadityasinha-dotcom for metric parameter there are more then 1 distance metric

do consider consider adding following distance metrics mentioned in the official documentation: https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.DistanceMetric.html#sklearn.neighbors.DistanceMetric

I have added euclidean, manhattan, mahalanobis and other distances also as a parameter in the metric.

@Thilakraj1998
Copy link
Contributor

Thilakraj1998 commented Oct 7, 2021

@aadityasinha-dotcom
Required Changes:

  1. Redundant metric initialization
  2. keep outlier label value has most_frequent
  3. change range in radius parameter "radius":{'float':[1.0,10.0]},
  4. "metric":{'str':['euclidean', 'manhattan', 'chebyshev', 'minkowski']} use only following distance metric due extra args required.

@aadityasinha-dotcom
Copy link
Contributor Author

@Thilakraj1998 I have made some changes according to your instructions, can you review that?

@Thilakraj1998 Thilakraj1998 added the hacktoberfest-accepted For accepting PR of participants in Hacktoberfest label Oct 11, 2021
@Thilakraj1998 Thilakraj1998 merged commit a9de9ba into blobcity:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted For accepting PR of participants in Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants