Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the parameters for the Nearest Centroid Classifier #78

Closed
wants to merge 1 commit into from
Closed

Added the parameters for the Nearest Centroid Classifier #78

wants to merge 1 commit into from

Conversation

Tanuj2552
Copy link
Contributor

@Tanuj2552 Tanuj2552 commented Oct 4, 2021

By this commit will fix the issue of #47
Added the parameters for the Nearest Centroid Classification Model and tested it on the Pima Indians Diabetes Dataset (from 3rd data set present in the website https://machinelearningmastery.com/standard-machine-learning-datasets/ )

Added the parameters for the Nearest Centroid Classification Model
@Tanuj2552 Tanuj2552 changed the title Added the parameters for the Nearest Centroid Added the parameters for the Nearest Centroid Classifier Oct 4, 2021
@Thilakraj1998
Copy link
Contributor

@Tanuj2552
the model doesnt have l1 and l2 has parameter for metric
do refer official api parameters
https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.NearestCentroid.html?highlight=nearestcentroid#sklearn.neighbors.NearestCentroid

@Tanuj2552
Copy link
Contributor Author

Well, actually it does have those parameters. Those are not directly given in that nearest centroid API, but if we go through it, it says that it has the same metrics as for metrics.pairwise.pairwise_distances. Then I checked that API and it clearly states that these parameters are available, and I have verified it by testing it with a classification dataset.
Please check once again and let me know.

@Thilakraj1998
Copy link
Contributor

@Tanuj2552 then do add manhattan and euclidean metric too

@Tanuj2552
Copy link
Contributor Author

yeah sure.
so for that, should I again make a new pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants