Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large CPU hit after 1200p resize #134

Closed
BlackPowerade opened this issue Sep 26, 2021 · 2 comments
Closed

Large CPU hit after 1200p resize #134

BlackPowerade opened this issue Sep 26, 2021 · 2 comments

Comments

@BlackPowerade
Copy link

BlackPowerade commented Sep 26, 2021

Describe the bug

Resizing the player window beyond ~1200h results in a massive CPU utilization spike with Anime4K enabled.

To Reproduce

Steps to reproduce the behavior:

  1. Load up 480p video
  2. Enable Anime4K
  3. Resize player beyond ~1200h

Expected behavior

Non-massive performance hit

Screenshots

Below Breakpoint:

general information below breakpoint
Shaders below breakpoint
system stats below breakpoint

Above Breakpoint:

general information above breakpoint
shaders beyond breakpoint
system stats above breakpoint

Desktop:

  • OS: Windows 10 Enterprise 21H1, 19043
  • Version: 4.0.1 Stable
  • GPU: RTX 2070 Super
  • Media Player and Version: mpv 0.33.0-107-gdd86f195a6
  • Browser: Edge 94.0.992.31

Additional context

From what I can tell this appears to be a copyback issue, as switching from nvdec-copy to nvdec significantly alleviated the problem. Not enough to fix it, still too much frame dropping.
This issue is present on all renderers, with the same similar results where the non-copy version performs much better.
I am not entirely sure where the breakpoint is, I could not get mpv to tell me the current window size. Best I can surmise is somewhere upwards of 1180ish.
This looks like it may be related to mpv-player/mpv#8613 and #119

Current mpv.conf is as follows:

input-default-bindings = no
input-ar-delay = 500
input-ar-rate = 20
keep-open = yes
keep-open-pause = no
osd-duration = 2000
script-opts = osc-scalewindowed=1.5,osc-hidetimeout=2000,console-scale=1
screenshot-directory = '~~desktop/'
hwdec = nvdec-copy
# Editor
scale = spline36
screenshot-format = png
save-position-on-quit = yes
cscale = spline36
dscale = spline36
osd-playing-msg = '${display-width}'

[protocol.https]
osd-playing-msg = '${media-title}'
@BlackPowerade BlackPowerade changed the title Large CPU hit after 960p resize Large CPU hit after 1200p resize Sep 26, 2021
@bloc97
Copy link
Owner

bloc97 commented Sep 27, 2021

The mpv version might be too old. The latest Anime4K shaders will not work for versions previous to this update: mpv-player/mpv@474ee00

Try the latest nightly windows builds, they should not have this issue anymore.

@BlackPowerade
Copy link
Author

Yep, that fixed it.
Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants