Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Instructions for Linux and Minor change to Issue Template #170

Merged
merged 7 commits into from Apr 10, 2022

Conversation

WasteOfO2
Copy link
Contributor

Hi, sorry for the late PR :P

Haven't had much time recently so I just managed to squeeze this in

Do need a little bit of revamp for Windows. Won't mind doing it if requested

Alternatively, this can be merged into the wiki as i believe it makes much more sense to put it in there

Also, I have added a small change to the Issue Template for bugs to give more details for Linux users, just to make it a bit more easier to troubleshoot

@bloc97
Copy link
Owner

bloc97 commented Apr 10, 2022

Thanks, looks great! I also now think it might be better to eventually move the usage instructions to the wiki, maybe one instruction page for each OS as the instructions are starting to get heavy and might be hard to follow for novice users...

@bloc97 bloc97 merged commit fc4f9e2 into bloc97:master Apr 10, 2022
@bloc97
Copy link
Owner

bloc97 commented Apr 10, 2022

In fact I just remembered why I did not put the install instructions to the wiki. It is not possible to link to older instructions in the releases section. Currently older releases have their instructions linking to the version branch, and using the wiki would not allow that (AFAIK), could be wrong. I think it would be better to just split the instructions into three files.

  • Windows installation guide
  • Linux installation guide
  • Advanced usage guide (3rd part of the current installation instructions)

@WasteOfO2
Copy link
Contributor Author

Or we can just copy paste this stuff in the wiki, i think that works too

@abhigit23
Copy link

abhigit23 commented Apr 12, 2022

Hey, could you do the same for the Flatpak version of mpv? I think flatpak is the easiest way to install mpv and it's available on almost all linux distros. You just need to put conf files and shaders to ~/.var/app/io.mpv.Mpv/mpv instead of ~/.config/mpv

like this:-
~/.var/app/io.mpv.Mpv/config/mpv/mpv.conf
~/.var/app/io.mpv.Mpv/config/mpv/input.conf
~/.var/app/io.mpv.Mpv/config/mpv/shaders
~/.var/app/io.mpv.Mpv/config/mpv/scripts

Reference from:-
https://flathub.org/apps/details/io.mpv.Mpv

I appreciate you added the guide for linux users too but if it's not too hassle to add Flatpak guide in the Linux section, you can think about it, otherwise you can ignore it.

@WasteOfO2
Copy link
Contributor Author

Hey, could you do the same for the Flatpak version of mpv? I think flatpak is the easiest way to install mpv and it's available on almost all linux distros. You just need to put conf files and shaders to ~/.var/app/io.mpv.Mpv/mpv instead of ~/.config/mpv

like this:- ~/.var/app/io.mpv.Mpv/config/mpv/mpv.conf ~/.var/app/io.mpv.Mpv/config/mpv/input.conf ~/.var/app/io.mpv.Mpv/config/mpv/shaders ~/.var/app/io.mpv.Mpv/config/mpv/scripts

Reference from:- https://flathub.org/apps/details/io.mpv.Mpv

I appreciate you added the guide for linux users too but if it's not too hassle to add Flatpak guide in the Linux section, you can think about it, otherwise you can ignore it.

Hey, thanks for pointing that out

It does make sense to add it, I will open a PR appending the information above, or you can do so as well

Thanks!

@abhigit23
Copy link

Hey, thanks for pointing that out

It does make sense to add it, I will open a PR appending the information above, or you can do so as well

Thanks!

Hello, I have opened a PR, you can review it. If you find any problems let me know. It's literally my first PR here so please pardon if I miss something or lack in the quality.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants