Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The differences from the official implementation? #24

Closed
cliangyu opened this issue Oct 31, 2022 · 1 comment
Closed

The differences from the official implementation? #24

cliangyu opened this issue Oct 31, 2022 · 1 comment

Comments

@cliangyu
Copy link

Hi developers, thank you for completing this wonderful re-implementation.
As I am checking the differences between this repo and the original one, I noticed that the original repo also implemented stable diffusion.

I am wondering if you would like to list the additional features, those exclusive in this repo, on the README page. Will appreciate your clarification very much!

@bloc97
Copy link
Owner

bloc97 commented Oct 31, 2022

Hi, this implementation was done before the authors had released the code, so in a sense, the official repo's code is more "correct" with respect to the paper, while here I had to take some guesses and add a few modifications.

Currently there are three main differences:

  • As there is zero code overlap between the two repos, the license and code ownership is different, (this one is licensed under MIT, official one is Apache)
  • The official repo has implemented local editing (using the cross attention masks), while this one does not. [Figure 12, page 12 in the paper]
  • This repo has implemented image inversion (finding the latent given an image), while the official repo does not (at least not currently). [Figure 10, page 11 in the paper]

While the actual implementation of the cross-attention control/injection might be slightly different, the results are mostly the same, as I tried to be as faithful to the paper but had to modify the algorithms slightly for stable diffusion. I guess the original authors had to do the same thing but in a different way.

@cliangyu cliangyu closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants