Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbortController is not defined #566

Open
Neurone opened this issue Sep 2, 2023 · 0 comments
Open

AbortController is not defined #566

Neurone opened this issue Sep 2, 2023 · 0 comments

Comments

@Neurone
Copy link
Contributor

Neurone commented Sep 2, 2023

Describe the bug
Running the test suite you get tons of errors like:

Retrying request... ReferenceError: AbortController is not defined
    at /home/developer/workspace/extension/packages/background/src/utils/http.ts:2:2937

AbortController was introduced since NodeJS 15, but the required NodeJS version in .npmrc is 14.17.6. I suggest to upgrade to a newer version. I.e., I tried the test suite with NodeJS 16 and everything looks fine.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repo
  2. make install
  3. make build
  4. make test
  5. See errors

Expected behavior
Test suite runs without errors.

Screenshots
N/A.

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: N/A
  • Version: v1.1.6

Additional context
N/A

@Neurone Neurone changed the title AbortController AbortController is not defined Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant