Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will bitcoin-etl support the BTC taproot soft fork #53

Open
cberson-asymmetrik opened this issue Sep 1, 2021 · 4 comments
Open

Will bitcoin-etl support the BTC taproot soft fork #53

cberson-asymmetrik opened this issue Sep 1, 2021 · 4 comments

Comments

@cberson-asymmetrik
Copy link

Hi, I was wondering if bitcoin-etl will be supporting the BTC taproot soft fork coming in November. The changes are outlined in BIP340, BIP341, and BIP342.

Thanks!

@medvedev1088
Copy link
Member

Hi, we'll have to look into it. We rely on the bitcoin node API and do minimal processing in this tool so if the changes will be reflected in the API we'll just need to upgrade our nodes

@mdragaschnig
Copy link
Contributor

mdragaschnig commented Nov 18, 2021

I tested with tx 777c998695de4b7ecec54c058c73b2cab71184cf1655840935cd9388923dc288 in block 709632:

From the bitcoin node API response

txid | "777c998695de4b7ecec54c058c73b2cab71184cf1655840935cd9388923dc288"
[...]
vin | […]
vout |  0 |   value | 0.0003 n | 0
scriptPubKey |  
   asm | "1 667bdd93c7c029767fd516…a175ac9f1220cf508963ff3"
   hex | "5120667bdd93c7c029767fd5…a175ac9f1220cf508963ff3"
  address | "bc1pveaamy78cq5hvl74zmfw…44j03ygx02zyk8lesgk06f6"
   type | "witness_v1_taproot"
[...]

using BtcStreamerAdapter.export_blocks_and_transactions() I get

{'index': 0, 'script_asm': '1 667bdd93c7c029767fd516d2ea292624b938fefefa175ac9f1220cf508963ff3', 'script_hex': '5120667bdd93c7c029767fd516d2ea292624b938fefefa175ac9f1220cf508963ff3', 'required_signatures': None, 'type': 'nonstandard', 'addresses': ['nonstandardd3b29c9218fdc3ba0a265fc7cfb1d692ad9e4e18'], 'value': 30000}

The address and type information is lost because the dict key used for creating a BtcTransactionOutput does not match the API response data: 'addresses' vs. 'address'

output.addresses = script_pub_key.get('addresses')

Edit: #55 (comment)
"The root cause of this issue is that core 22.0 changed the raw json structure."

@Trudko
Copy link

Trudko commented Dec 20, 2021

Any updates on this please?

@medvedev1088
Copy link
Member

It's been added in this PR #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants