-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all usage of redux-ui in favor React Redux/Redux Saga #857
Comments
@schnogz I would like to get on this when I can! It looks like they are mostly in the container files. Would you have a preference on where to start? |
@mchlcrtz that would be great. Some of the easiest spots would be in the Security Center. |
Hi @schnogz, should I be adding my own sagas in blockchain-wallet-v4-frontend/src/data? If so, can you describe the design of data flow in that directory? Thank you! Also, with simple ui state changes such as toggling, would it be okay to handle them with normal actions/reducers? |
I think most code that uses redux-ui is pretty simple stuff such as toggle states and what not. You can just use the standard react component state to handle all this. Here is an example: Edit: I see that you have already made a PR for some of this using redux. I will take a look later today but we probably want to redo it to use just react states. sorry about that man. |
Can we close this? |
Closing! |
🐛 Bug Report (Tech Debt) 🐛
Description
When the codebase first started out, redux-ui was used in a few spots for quick state management. Now that we have defined consistent patterns for state management via React Redux & Redux Saga, let's remove redux-ui completely in favor of the latter.
Expected Outcomes
All usages of redux-ui are eventually removed. This can be done all at once or incrementally, whichever works best.
Additional Information
redux-ui Docs: https://github.com/tonyhb/redux-ui
React Redux Docs: https://github.com/reduxjs/react-redux
Redux Saga Docs: https://github.com/redux-saga/redux-saga
The text was updated successfully, but these errors were encountered: