Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned Arbitrary instances are brought into scope by the Blockfrost.Client #35

Closed
Unisay opened this issue Jan 9, 2023 · 2 comments
Closed

Comments

@Unisay
Copy link
Contributor

Unisay commented Jan 9, 2023

Actual situation

Fact 1:
The quickcheck-instances library has this warning in its documentation:

Since all of these instances are provided as orphans, I recommend that you do not use this library within another library module, so that you don't impose these instances on down-stream consumers of your code.

Fact 2:
Blockfrost API library uses quickcheck-instances

Fact 3:
blockfrost-api is a library that ignores the warning and causes problems associated with the orphaned instances to its users, even transitively, via the blockfrost-client dependency.

Desired situation

blockfrost-api doesn't bring orphaned instances to scope for all its downstream users.

@sorki
Copy link
Contributor

sorki commented Jan 10, 2023

Thanks! These are all leftovers that belong to internal package, removed in #36.

@sorki sorki closed this as completed in 30fc15d Jan 10, 2023
@sorki
Copy link
Contributor

sorki commented Jan 10, 2023

Published on Hackage as blockfrost-api 0.8.0.0 and blockfrost-client 0.7.1.1 that allows api 0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants