Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integration tests to use vitest instead jest #46

Closed
LeonardoVieira1630 opened this issue Mar 21, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@LeonardoVieira1630
Copy link
Member

Refactor Request

Describe the Refactor Request

In the integration tests branch, it was used jest. Otherwise, in some parts of the project, it is being used vitest, that is newer and more performative.
So, to make a more concise and more performative code, the integration tests need to be refactored.

Describe Preferred Solution

To complete the issue, the integration test needs to import vitest functions and definitions, like beforeAll, it and describe. None of jest definitions will be used after the modification.

Related Code

An example of test the is using the vitest already can be seen at: https://github.com/blockful-io/external-resolver/blob/integrationTests/packages/client/test/public.test.ts

Additional Context

vitest docs: https://vitest.dev/guide/

@pikonha
Copy link
Contributor

pikonha commented Mar 26, 2024

is there a PR for this?

@LeonardoVieira1630 LeonardoVieira1630 mentioned this issue Mar 27, 2024
10 tasks
@pikonha pikonha closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants