Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compose swap on the factory is not necessary as it can be delegate to the implementer #15

Closed
0xneves opened this issue Oct 30, 2023 · 3 comments · Fixed by #44
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@0xneves
Copy link
Member

0xneves commented Oct 30, 2023

It's currently being used by the tests of swaplace, thus the need to create a utils.ts script to compose the swaps using typescript and then call it on the test files.

  • Delete all about composing swaps in the SwapFactory.
  • Forge utils file to aid swap making in tests
  • Update all tests previously using composeSwap
  • @edit add virtual keyword to the function in the SwaplaceFactory
@0xneves
Copy link
Member Author

0xneves commented Oct 31, 2023

Adding a refactor on setting the makeAsset and makeSwap functions into virtual for possible override by the implementer.

@0xneves
Copy link
Member Author

0xneves commented Oct 31, 2023

I'm rushing this as it interferes with more issues that need to be executed

@0xneves
Copy link
Member Author

0xneves commented Nov 3, 2023

Instead of utils.ts, SwapFactory.ts should be better, this would separate the logic for composing swaps in a file and the general utilities in the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: ✅ Done
1 participant