Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: native ether and ERC1155 swaps #204

Closed
8 tasks done
0xneves opened this issue Apr 21, 2024 · 3 comments
Closed
8 tasks done

epic: native ether and ERC1155 swaps #204

0xneves opened this issue Apr 21, 2024 · 3 comments
Assignees
Labels
epic Epic groups normal issues help wanted Extra attention is needed Hot Task Doubled points in the reward table

Comments

@0xneves
Copy link
Member

0xneves commented Apr 21, 2024

Feature Request

Describe the Feature Request

The revision branch is out and needs a few tests to guarantee the contract is working correctly. The main subjects that need to be addressed in this epic are:

  • Swap with Native Ether
  • Swap with ERC1155
  • Unitary Tests
  • Scripts

Please ping me on GitHub so I can address an issue to you in case you're interested. One at a time, please!
Please ping me on Discord for questions regarding the issues below. Happy coding.

Describe Preferred Solution

TARGET BRANCH: REVISION

Additional Context

Check how the native ether transfer works

@0xneves 0xneves added help wanted Extra attention is needed Hot Task Doubled points in the reward table epic Epic groups normal issues labels Apr 21, 2024
@0xneves 0xneves self-assigned this Apr 21, 2024
@blackbeard002
Copy link
Contributor

Hey @0xneves will I be getting assigned for this as well since I closed it all? 👀 😂

@0xneves
Copy link
Member Author

0xneves commented May 20, 2024

Hey @0xneves will I be getting assigned for this as well since I closed it all? 👀 😂

This is not an issue, but rather an epic, only means for tracking and managements, thus why I'm assigned

@0xneves 0xneves closed this as completed May 20, 2024
@blackbeard002
Copy link
Contributor

Hey @0xneves will I be getting assigned for this as well since I closed it all? 👀 😂

This is not an issue, but rather an epic, only means for tracking and managements, thus why I'm assigned

Yeah yeah I was just kidding 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epic groups normal issues help wanted Extra attention is needed Hot Task Doubled points in the reward table
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants