Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust legacy installation dependencies #93

Open
2 tasks
heronlancellot opened this issue Feb 7, 2024 · 10 comments
Open
2 tasks

refactor: adjust legacy installation dependencies #93

heronlancellot opened this issue Feb 7, 2024 · 10 comments
Labels
enhancement New features hot task Doubled points in the reward table

Comments

@heronlancellot
Copy link
Member

Refactor Request

Describe the Refactor Request

The Definition of done is implementing

  • Remove npm i ( legacy-peer-deps ) to install packages.
  • try npm i and check if the dApp works perfectly.

Describe Preferred Solution

Check out the packages, like @rainbow-me/rainbowkit-siwe-next-auth and the others.
The repo should work perfectly without running legacy-peer-deps.
Fix the package.json

Describe Alternatives

If have any other solution or improvement, let us know ! 🙏✌️

Related Code

package.json

@heronlancellot heronlancellot added the enhancement New features label Feb 7, 2024
@0xneves 0xneves added the hot task Doubled points in the reward table label Feb 16, 2024
@blackbeard002
Copy link
Contributor

Hey @heronlancellot I'd like to work on this

@heronlancellot
Copy link
Member Author

Hey @heronlancellot I'd like to work on this

hey yo @blackbeard002 ! Assigned to you !

@0xneves
Copy link
Member

0xneves commented Mar 13, 2024

Any progress on this submission @blackbeard002 ? I know its quite hard !

@blackbeard002
Copy link
Contributor

Hey @0xneves won't be able to fix the issue on time. Could you unassign me?
So far was able to fix the first two dependency issues.

@heronlancellot
Copy link
Member Author

Hey @0xneves won't be able to fix the issue on time. Could you unassign me? So far was able to fix the first two dependency issues.

hey yo @blackbeard002 ! Perfect man, thanks for letting us know !! 🙏 🙏

@gabrieljolvm
Copy link
Contributor

@0xneves I solved this task, if you give it to me, I can commit. The problem is, to solve this, wagmi and its dependencies were updated and with that, the documentation changes from version v1 to v2. In v2, the code that is present in wallet.config will be changed, which in this case would be a new task beyond this one.

@0xneves
Copy link
Member

0xneves commented Apr 10, 2024

Thank you @gabrieljolvm for using your valuable time on this issue.
I'm assigning this to you and waiting for your PR so we can address the problem that will come with it.

@heronlancellot
Copy link
Member Author

hey yo ! any update of this issue @gabrieljolvm ?

@gabrieljolvm
Copy link
Contributor

Sorry, i'll update this issue until tomorrow. @heronlancellot

@Mouradif
Copy link

Hey I was just taking a look, seems like this is solved. I've checked out the develop branch, filled in my .env, ran npm i then npm run dev and it looks like it's working just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features hot task Doubled points in the reward table
Projects
Status: 🔖 TODO
Development

No branches or pull requests

5 participants