Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include original txHash in speedup/cancel events #316

Closed
cmeisl opened this issue Jul 4, 2019 · 0 comments · Fixed by #317
Closed

Include original txHash in speedup/cancel events #316

cmeisl opened this issue Jul 4, 2019 · 0 comments · Fixed by #317
Labels
enhancement New feature or request

Comments

@cmeisl
Copy link
Member

cmeisl commented Jul 4, 2019

When a transaction is sped up or canceled, its transaction hash changes (i.e. its a new transaction with the same nonce at a higher gas price, which drops the original transaction).

Include the original transactions hash in the txSpeedup and txCancel messages so Dapp can easily see which transaction was replaced.
@cmeisl cmeisl added the enhancement New feature or request label Jul 4, 2019
@cmeisl cmeisl mentioned this issue Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Original hash blocknative/assist
1 participant
@cmeisl