Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical dependency warning when using Magic Wallet Module #173

Closed
leovct opened this issue Mar 24, 2022 · 1 comment
Closed

Critical dependency warning when using Magic Wallet Module #173

leovct opened this issue Mar 24, 2022 · 1 comment

Comments

@leovct
Copy link

leovct commented Mar 24, 2022

Description

The demo compiles with warnings when importing the magic wallet module.
If you remove or comment the import, the app compiles successfully.

Compiled with warnings.

./node_modules/magic-sdk/dist/es/index.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracte
...

Environment

  • Fedora Linux 35 (Workstation)
  • Npm 8.5.5
  • Node v16.14.0
  • React Demo 0.15.0
  • @web3-onboard/magic 2.0.0
@Adamj1232
Copy link
Member

@leovct this is the Magic team's response to the issue. We will be looking at fixing on the demo shortly
magiclabs/magic-js#295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants