Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

View posts by user should (optionally) include resteems. #46

Open
toniwidmo opened this issue May 6, 2018 · 4 comments
Open

View posts by user should (optionally) include resteems. #46

toniwidmo opened this issue May 6, 2018 · 4 comments
Assignees
Milestone

Comments

@toniwidmo
Copy link
Collaborator

At the moment a users posts, as viewed on either the post listing page, or their profile page, excludes resteems. It would be good if it could optionally include them.

@toniwidmo
Copy link
Collaborator Author

https://jsfiddle.net/bonustrack/24b7ky2s/2/

^ This should help.

@toniwidmo
Copy link
Collaborator Author

Basically, in module/steem.js we currently use steem.api.getDiscussionsByAuthorBeforeDate to get the users steem posts. Instead we should use steem.api.getDiscussionsByBlog if we want to get resteems.

Do we want lists without resteems? If so, do we just hide them using css/javascript? Or do we need both get methods triggered by a config switch?

In option 1 we are saying decision to hide resteems is a theme/styling decision.
In option 2 we are saying code should know what we doing an handle appropriately.

In option 1, changing theme will change behaviour of listing.
In option 2, changing theme will not change behaviour. Only changing config will.

@DanaVarahi
Copy link
Collaborator

In my opinion option, 2 is better. It seems more logical that this change/decision should be determined in the config file and not in the theme.

@toniwidmo
Copy link
Collaborator Author

I agree. If a site admin wants one or the other behaviour, they won't want changing a theme to mess it up. Option 2 gives them more flexibility.

@toniwidmo toniwidmo self-assigned this Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants