Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a theme with the source code, return a new theme if modified #49

Open
johno opened this issue Nov 25, 2019 · 1 comment
Open
Labels
🎨 theming Issues related to theming and theme-ui 💻 editor JSX-based page builder 🙏 good first issue Issues that are more friendly to newcomers
Projects

Comments

@johno
Copy link
Member

johno commented Nov 25, 2019

This requires us to set the theme that's passed in for the canvas and rendered blocks (which I believe we might be doing) and then handle the theme change by calling onThemeChange when the theme panel is edited.

The API would look something like the following:

<Editor
  src={myJSX}
  theme={myTheme}
  onChange={handleJSXChange}
  onThemeChange={handleThemeChange}
/>
@johno johno added 🎨 theming Issues related to theming and theme-ui 💻 editor JSX-based page builder labels Nov 25, 2019
@johno johno added this to To do in Roadmap via automation Nov 25, 2019
@johno johno added the 🙏 good first issue Issues that are more friendly to newcomers label Jan 23, 2020
@joeynimu
Copy link

@johno Hi, I'd like to take this one on if you can guide me if that's okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 theming Issues related to theming and theme-ui 💻 editor JSX-based page builder 🙏 good first issue Issues that are more friendly to newcomers
Projects
Roadmap
  
To do
Development

No branches or pull requests

2 participants