Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes colors are semantic names and sometimes hex colors #74

Closed
ChristopherBiscardi opened this issue Nov 26, 2019 · 2 comments
Closed

Sometimes colors are semantic names and sometimes hex colors #74

ChristopherBiscardi opened this issue Nov 26, 2019 · 2 comments
Labels
🎨 theming Issues related to theming and theme-ui 💻 editor JSX-based page builder
Projects
Roadmap

Comments

@ChristopherBiscardi
Copy link
Member

The issue is: It's hard to determine why one or the other is used

sx={{
  color: "#3333ee",
  bg: "muted"
}}

image
@ChristopherBiscardi ChristopherBiscardi added the 💻 editor JSX-based page builder label Nov 26, 2019
@johno johno added the 🎨 theming Issues related to theming and theme-ui label Nov 26, 2019
@johno johno added this to To do in Roadmap Dec 1, 2019
@jxnblk
Copy link
Contributor

jxnblk commented Dec 2, 2019

Think this might be a bug in @theme-ui/editor and how it attempts to look up the color's key and falls back to the raw value if it's not found

@jordanoverbye jordanoverbye mentioned this issue Dec 3, 2019
Merged
@jordanoverbye
Copy link
Member

@jxnblk Yeah it is. I've just opened a PR to fix that

Roadmap automation moved this from To do to Done Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 theming Issues related to theming and theme-ui 💻 editor JSX-based page builder
Projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChristopherBiscardi @johno @jxnblk @jordanoverbye