Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Contributor, I should see Internal Transaction Values as Ether instead of Wei. #13

Closed
acravenho opened this issue Mar 6, 2018 · 3 comments
Assignees
Labels
bug 🐛 Something isn't working enhancement New feature or request team: contributor Vienna
Milestone

Comments

@acravenho
Copy link
Contributor

acravenho commented Mar 6, 2018

Here is an example of the bug:
https://explorer-sokol.poa.network/en/transactions/0xbba93e1145f962ef1191a971e4db2d5eea30208dfb5e3588ce420c009e57a1d2/internal

The value should be in Ether.

@acravenho acravenho added this to Icebox in Contributors Section Mar 13, 2018
@acravenho acravenho moved this from Icebox to ToDo in Contributors Section Mar 13, 2018
@acravenho acravenho added bug 🐛 Something isn't working and removed to do labels Mar 13, 2018
@acravenho acravenho added this to the Vienna milestone May 4, 2018
@jimmay5469 jimmay5469 moved this from ToDo to In Progress in Contributors Section May 24, 2018
@ghost ghost assigned jimmay5469 May 24, 2018
@ghost ghost added the in progress label May 24, 2018
@jimmay5469
Copy link
Contributor

@acravenho It looks like this has already been resolved. Can you confirm?

@acravenho
Copy link
Contributor Author

Yes, this was resolved. 😄

@jimmay5469
Copy link
Contributor

Awesome, closing!

Contributors Section automation moved this from In Progress to Done May 24, 2018
@ghost ghost removed the in progress label May 24, 2018
@jimmay5469 jimmay5469 added Vienna and removed Vienna labels May 25, 2018
jcortejoso added a commit to jcortejoso/blockscout that referenced this issue Oct 17, 2019
* Theme modifications for Celo theme

* Added theme variable file

* apply celo theme and images

* add integration and betanet
vbaranov pushed a commit that referenced this issue Aug 31, 2020
ivanshukhov pushed a commit to planq-network/blockscout that referenced this issue Sep 2, 2022
* Update css from design team feedback

* Cleanup Code

* Update banner layout of home page

* Update for code optimization

* Comment out useless code

* Update gettext; code cleaning up

* Code reformat

* Update gettext
vbaranov added a commit that referenced this issue Sep 12, 2022
* Auth for debug

Fix for Auth callback calls endless cycle

* Logout from auth0 and add profile picture

Fix styles in signin/signout

* Add profile

* Update dockerfiles

* Make auth paths dependent of API_PATH

* Change api_path to network_path

* Save identity from auth into DB

* Hardcode urls to make it work again

Style fixes

* Change sign_in icon

* Create Watchlist together with identity

* Add watchlist show

* Add watchlist addresses

Fix creating account on first login

Make address as it should look like

* Associate watchlist with addresses

* Create watchlist address UI

Add balance in coin (need to use right coin)

* Add tokens on watchlist

Fix warnings

Fix topnav styles

* Add watch_ and notify_ fields in WatchlistAddress

* Notifications draft

Style fixes

Removed divider
Watchlist Address Form:
ERC-721 & ERC-1155 -> NFT
Form style -> modal
Move Auth into Account module

Add any valid address to watchlist

Fix profile namespace in router

Fixes in build Notification

Fixed insert notifications

* Send Emails via SendGrid

* Add AUTH0 & SENDGRID API keys to Makefile

* Finish email variables

Fix warnings

Add links to email

* Update & Delete Watchlist Addresses

Fix styles

Fix warnings

* Authorize create/update watchlist_address

Fix credo warnings

* Refactoring and fix UI

* Introduce sender & template ENVs

* Fix credo warns

* Fix formatter & dialyzer

* Make Notifier main entrypoint

* Fix tests

* Fix comments

* Hardcode auth0 callbacks for prod env

Export it in dev env and it should work:
```
export AUTH0_CALLBACK_URL='http://localhost:4000/auth/auth0/callback'
export AUTH0_LOGOUT_RETURN_URL='http://localhost:4000/auth/logout'
```

* Style fixes

* Private tags on address/transaction/token pages

* Add account logger

* fix email subject

* Fix token_transfers notifications

* Prepare for release

* Fix transaction dropdown

* Remoe unwanted changes

* Reset CI cache

* Fix Dialyzer, gettext

* Add logout_return_to_url to :ueberauth config for test env

* Invalidate GA cache

* Redefine sign_in_link for test env

* Fix adding address with disabled checkboxes

Remove testnet hardcode from prod config

CI fix attempt

* Add AUTH0_LOGOUT_URL env

* Fix logger warning

* current_user/1, check that mapping contains :current_user object before executing get_session function

* Fix current_user

* Final fix of current_user/1

* Introduce COIN_NAME env

* Lowercase hashes in email

* Style fix

* Add block_url to email

* Fix creating notifications for NFT

* Add notifier to token_transfers import runner

* Add processing transfer into Notifier

* Fix token transfer summary

* WIP: Account refactoring (#19)

* Move Ueberauth settings to config.exs

* Make AuthController more clear

* Fix error when build_watchlist_notification returns nil

* Set WatchlistAddressForm defaults

* Style fix

* Fix double send email for tokens

* Style fix WatchlistController

* Style fix AddWatchlistAddress

* Style fix UserFromAuth

* Use Logger instead AccountLogger

* Credo fix

* Fix AddWatchlistAddress

* Fix Notifier

Co-authored-by: Oleg Sovetnik <sovetnik@oblaka.biz>
Co-authored-by: nikitosing <nikitosing4@mail.ru>
vbaranov added a commit that referenced this issue Sep 14, 2022
* Auth for debug

Fix for Auth callback calls endless cycle

* Logout from auth0 and add profile picture

Fix styles in signin/signout

* Add profile

* Update dockerfiles

* Make auth paths dependent of API_PATH

* Change api_path to network_path

* Save identity from auth into DB

* Hardcode urls to make it work again

Style fixes

* Change sign_in icon

* Create Watchlist together with identity

* Add watchlist show

* Add watchlist addresses

Fix creating account on first login

Make address as it should look like

* Associate watchlist with addresses

* Create watchlist address UI

Add balance in coin (need to use right coin)

* Add tokens on watchlist

Fix warnings

Fix topnav styles

* Add watch_ and notify_ fields in WatchlistAddress

* Notifications draft

Style fixes

Removed divider
Watchlist Address Form:
ERC-721 & ERC-1155 -> NFT
Form style -> modal
Move Auth into Account module

Add any valid address to watchlist

Fix profile namespace in router

Fixes in build Notification

Fixed insert notifications

* Send Emails via SendGrid

* Add AUTH0 & SENDGRID API keys to Makefile

* Finish email variables

Fix warnings

Add links to email

* Update & Delete Watchlist Addresses

Fix styles

Fix warnings

* Authorize create/update watchlist_address

Fix credo warnings

* Refactoring and fix UI

* Introduce sender & template ENVs

* Fix credo warns

* Fix formatter & dialyzer

* Make Notifier main entrypoint

* Fix tests

* Fix comments

* Hardcode auth0 callbacks for prod env

Export it in dev env and it should work:
```
export AUTH0_CALLBACK_URL='http://localhost:4000/auth/auth0/callback'
export AUTH0_LOGOUT_RETURN_URL='http://localhost:4000/auth/logout'
```

* Style fixes

* Private tags on address/transaction/token pages

* Add account logger

* fix email subject

* Fix token_transfers notifications

* Prepare for release

* Fix transaction dropdown

* Remoe unwanted changes

* Reset CI cache

* Fix Dialyzer, gettext

* Add logout_return_to_url to :ueberauth config for test env

* Invalidate GA cache

* Redefine sign_in_link for test env

* Fix adding address with disabled checkboxes

Remove testnet hardcode from prod config

CI fix attempt

* Add AUTH0_LOGOUT_URL env

* Fix logger warning

* current_user/1, check that mapping contains :current_user object before executing get_session function

* Fix current_user

* Final fix of current_user/1

* Introduce COIN_NAME env

* Lowercase hashes in email

* Style fix

* Add block_url to email

* Fix creating notifications for NFT

* Add notifier to token_transfers import runner

* Add processing transfer into Notifier

* Fix token transfer summary

* WIP: Account refactoring (#19)

* Move Ueberauth settings to config.exs

* Make AuthController more clear

* Fix error when build_watchlist_notification returns nil

* Set WatchlistAddressForm defaults

* Style fix

* Fix double send email for tokens

* Style fix WatchlistController

* Style fix AddWatchlistAddress

* Style fix UserFromAuth

* Use Logger instead AccountLogger

* Credo fix

* Fix AddWatchlistAddress

* Fix Notifier

Co-authored-by: Oleg Sovetnik <sovetnik@oblaka.biz>
Co-authored-by: nikitosing <nikitosing4@mail.ru>
vbaranov added a commit that referenced this issue Sep 14, 2022
* Auth for debug

Fix for Auth callback calls endless cycle

* Logout from auth0 and add profile picture

Fix styles in signin/signout

* Add profile

* Update dockerfiles

* Make auth paths dependent of API_PATH

* Change api_path to network_path

* Save identity from auth into DB

* Hardcode urls to make it work again

Style fixes

* Change sign_in icon

* Create Watchlist together with identity

* Add watchlist show

* Add watchlist addresses

Fix creating account on first login

Make address as it should look like

* Associate watchlist with addresses

* Create watchlist address UI

Add balance in coin (need to use right coin)

* Add tokens on watchlist

Fix warnings

Fix topnav styles

* Add watch_ and notify_ fields in WatchlistAddress

* Notifications draft

Style fixes

Removed divider
Watchlist Address Form:
ERC-721 & ERC-1155 -> NFT
Form style -> modal
Move Auth into Account module

Add any valid address to watchlist

Fix profile namespace in router

Fixes in build Notification

Fixed insert notifications

* Send Emails via SendGrid

* Add AUTH0 & SENDGRID API keys to Makefile

* Finish email variables

Fix warnings

Add links to email

* Update & Delete Watchlist Addresses

Fix styles

Fix warnings

* Authorize create/update watchlist_address

Fix credo warnings

* Refactoring and fix UI

* Introduce sender & template ENVs

* Fix credo warns

* Fix formatter & dialyzer

* Make Notifier main entrypoint

* Fix tests

* Fix comments

* Hardcode auth0 callbacks for prod env

Export it in dev env and it should work:
```
export AUTH0_CALLBACK_URL='http://localhost:4000/auth/auth0/callback'
export AUTH0_LOGOUT_RETURN_URL='http://localhost:4000/auth/logout'
```

* Style fixes

* Private tags on address/transaction/token pages

* Add account logger

* fix email subject

* Fix token_transfers notifications

* Prepare for release

* Fix transaction dropdown

* Remoe unwanted changes

* Reset CI cache

* Fix Dialyzer, gettext

* Add logout_return_to_url to :ueberauth config for test env

* Invalidate GA cache

* Redefine sign_in_link for test env

* Fix adding address with disabled checkboxes

Remove testnet hardcode from prod config

CI fix attempt

* Add AUTH0_LOGOUT_URL env

* Fix logger warning

* current_user/1, check that mapping contains :current_user object before executing get_session function

* Fix current_user

* Final fix of current_user/1

* Introduce COIN_NAME env

* Lowercase hashes in email

* Style fix

* Add block_url to email

* Fix creating notifications for NFT

* Add notifier to token_transfers import runner

* Add processing transfer into Notifier

* Fix token transfer summary

* WIP: Account refactoring (#19)

* Move Ueberauth settings to config.exs

* Make AuthController more clear

* Fix error when build_watchlist_notification returns nil

* Set WatchlistAddressForm defaults

* Style fix

* Fix double send email for tokens

* Style fix WatchlistController

* Style fix AddWatchlistAddress

* Style fix UserFromAuth

* Use Logger instead AccountLogger

* Credo fix

* Fix AddWatchlistAddress

* Fix Notifier

Co-authored-by: Oleg Sovetnik <sovetnik@oblaka.biz>
Co-authored-by: nikitosing <nikitosing4@mail.ru>
vbaranov added a commit that referenced this issue Sep 14, 2022
* Auth for debug

Fix for Auth callback calls endless cycle

* Logout from auth0 and add profile picture

Fix styles in signin/signout

* Add profile

* Update dockerfiles

* Make auth paths dependent of API_PATH

* Change api_path to network_path

* Save identity from auth into DB

* Hardcode urls to make it work again

Style fixes

* Change sign_in icon

* Create Watchlist together with identity

* Add watchlist show

* Add watchlist addresses

Fix creating account on first login

Make address as it should look like

* Associate watchlist with addresses

* Create watchlist address UI

Add balance in coin (need to use right coin)

* Add tokens on watchlist

Fix warnings

Fix topnav styles

* Add watch_ and notify_ fields in WatchlistAddress

* Notifications draft

Style fixes

Removed divider
Watchlist Address Form:
ERC-721 & ERC-1155 -> NFT
Form style -> modal
Move Auth into Account module

Add any valid address to watchlist

Fix profile namespace in router

Fixes in build Notification

Fixed insert notifications

* Send Emails via SendGrid

* Add AUTH0 & SENDGRID API keys to Makefile

* Finish email variables

Fix warnings

Add links to email

* Update & Delete Watchlist Addresses

Fix styles

Fix warnings

* Authorize create/update watchlist_address

Fix credo warnings

* Refactoring and fix UI

* Introduce sender & template ENVs

* Fix credo warns

* Fix formatter & dialyzer

* Make Notifier main entrypoint

* Fix tests

* Fix comments

* Hardcode auth0 callbacks for prod env

Export it in dev env and it should work:
```
export AUTH0_CALLBACK_URL='http://localhost:4000/auth/auth0/callback'
export AUTH0_LOGOUT_RETURN_URL='http://localhost:4000/auth/logout'
```

* Style fixes

* Private tags on address/transaction/token pages

* Add account logger

* fix email subject

* Fix token_transfers notifications

* Prepare for release

* Fix transaction dropdown

* Remoe unwanted changes

* Reset CI cache

* Fix Dialyzer, gettext

* Add logout_return_to_url to :ueberauth config for test env

* Invalidate GA cache

* Redefine sign_in_link for test env

* Fix adding address with disabled checkboxes

Remove testnet hardcode from prod config

CI fix attempt

* Add AUTH0_LOGOUT_URL env

* Fix logger warning

* current_user/1, check that mapping contains :current_user object before executing get_session function

* Fix current_user

* Final fix of current_user/1

* Introduce COIN_NAME env

* Lowercase hashes in email

* Style fix

* Add block_url to email

* Fix creating notifications for NFT

* Add notifier to token_transfers import runner

* Add processing transfer into Notifier

* Fix token transfer summary

* WIP: Account refactoring (#19)

* Move Ueberauth settings to config.exs

* Make AuthController more clear

* Fix error when build_watchlist_notification returns nil

* Set WatchlistAddressForm defaults

* Style fix

* Fix double send email for tokens

* Style fix WatchlistController

* Style fix AddWatchlistAddress

* Style fix UserFromAuth

* Use Logger instead AccountLogger

* Credo fix

* Fix AddWatchlistAddress

* Fix Notifier

Co-authored-by: Oleg Sovetnik <sovetnik@oblaka.biz>
Co-authored-by: nikitosing <nikitosing4@mail.ru>
vbaranov added a commit that referenced this issue Sep 14, 2022
* Auth for debug

Fix for Auth callback calls endless cycle

* Logout from auth0 and add profile picture

Fix styles in signin/signout

* Add profile

* Update dockerfiles

* Make auth paths dependent of API_PATH

* Change api_path to network_path

* Save identity from auth into DB

* Hardcode urls to make it work again

Style fixes

* Change sign_in icon

* Create Watchlist together with identity

* Add watchlist show

* Add watchlist addresses

Fix creating account on first login

Make address as it should look like

* Associate watchlist with addresses

* Create watchlist address UI

Add balance in coin (need to use right coin)

* Add tokens on watchlist

Fix warnings

Fix topnav styles

* Add watch_ and notify_ fields in WatchlistAddress

* Notifications draft

Style fixes

Removed divider
Watchlist Address Form:
ERC-721 & ERC-1155 -> NFT
Form style -> modal
Move Auth into Account module

Add any valid address to watchlist

Fix profile namespace in router

Fixes in build Notification

Fixed insert notifications

* Send Emails via SendGrid

* Add AUTH0 & SENDGRID API keys to Makefile

* Finish email variables

Fix warnings

Add links to email

* Update & Delete Watchlist Addresses

Fix styles

Fix warnings

* Authorize create/update watchlist_address

Fix credo warnings

* Refactoring and fix UI

* Introduce sender & template ENVs

* Fix credo warns

* Fix formatter & dialyzer

* Make Notifier main entrypoint

* Fix tests

* Fix comments

* Hardcode auth0 callbacks for prod env

Export it in dev env and it should work:
```
export AUTH0_CALLBACK_URL='http://localhost:4000/auth/auth0/callback'
export AUTH0_LOGOUT_RETURN_URL='http://localhost:4000/auth/logout'
```

* Style fixes

* Private tags on address/transaction/token pages

* Add account logger

* fix email subject

* Fix token_transfers notifications

* Prepare for release

* Fix transaction dropdown

* Remoe unwanted changes

* Reset CI cache

* Fix Dialyzer, gettext

* Add logout_return_to_url to :ueberauth config for test env

* Invalidate GA cache

* Redefine sign_in_link for test env

* Fix adding address with disabled checkboxes

Remove testnet hardcode from prod config

CI fix attempt

* Add AUTH0_LOGOUT_URL env

* Fix logger warning

* current_user/1, check that mapping contains :current_user object before executing get_session function

* Fix current_user

* Final fix of current_user/1

* Introduce COIN_NAME env

* Lowercase hashes in email

* Style fix

* Add block_url to email

* Fix creating notifications for NFT

* Add notifier to token_transfers import runner

* Add processing transfer into Notifier

* Fix token transfer summary

* WIP: Account refactoring (#19)

* Move Ueberauth settings to config.exs

* Make AuthController more clear

* Fix error when build_watchlist_notification returns nil

* Set WatchlistAddressForm defaults

* Style fix

* Fix double send email for tokens

* Style fix WatchlistController

* Style fix AddWatchlistAddress

* Style fix UserFromAuth

* Use Logger instead AccountLogger

* Credo fix

* Fix AddWatchlistAddress

* Fix Notifier

Co-authored-by: Oleg Sovetnik <sovetnik@oblaka.biz>
Co-authored-by: nikitosing <nikitosing4@mail.ru>
shellteo pushed a commit to shellteo/blockscout that referenced this issue Jul 26, 2023
feat: prevent socket push for recent transactions
shellteo pushed a commit to shellteo/blockscout that referenced this issue Jul 26, 2023
blockscout#212 feat: add logo btn which can link to home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working enhancement New feature or request team: contributor Vienna
Projects
Development

No branches or pull requests

2 participants