Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ERC-721 UI Support #463

Closed
5 tasks
acravenho opened this issue Jul 25, 2018 · 5 comments
Closed
5 tasks

Provide ERC-721 UI Support #463

acravenho opened this issue Jul 25, 2018 · 5 comments

Comments

@acravenho
Copy link
Contributor

acravenho commented Jul 25, 2018

The completion of #447 adds support for ERC-721 tokens for the indexer. The frontend requires support as well for our v1 release. Here is a list of required pages and locations for ERC-721 support:

  • Account details page - dropdown tab
  • Account details page - transactions tab - token transfer list (type and tokenid)
  • Account details page - tokens tab
  • Token details page - overview section
  • Transaction details page - (type and tokenid)
@acravenho acravenho added this to the Vienna milestone Jul 25, 2018
@gfreh gfreh added this to To Do in Developers Section Jul 25, 2018
@gfreh gfreh moved this from To Do to Refining in Developers Section Aug 7, 2018
@gfreh gfreh added the paused Issues that have been held off for now. label Aug 8, 2018
@gfreh
Copy link

gfreh commented Aug 9, 2018

Hey, @acravenho! I've added below the status of each of the check-list items:

Based on that, it seems that the only item we haven't started yet is the Account details page: Tokens tab, which I believe we could implement with #410.

In this scenario, I believe we could close this issue. WDYT?

@jimmay5469
Copy link
Contributor

I added team:contributor to this as well so we can track the work for the mockup described in #448.

@gfreh
Copy link

gfreh commented Aug 9, 2018

@jimmay5469 we're going to close this issue. Do you prefer us to let it open and just remove team:developer label?

@gfreh gfreh removed paused Issues that have been held off for now. team: developer labels Aug 9, 2018
@gfreh gfreh removed this from Refining in Developers Section Aug 13, 2018
@acravenho acravenho modified the milestones: Vienna, Kuala Lumpur Sep 18, 2018
@acravenho
Copy link
Contributor Author

@vbaranov
Copy link
Member

The storage and display of NFT tokens metadata were added in the frame of the referenced issues ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants