Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate soundbank in NITROFATDIR when it is used #78

Closed
AntonioND opened this issue Jun 3, 2023 · 2 comments
Closed

Generate soundbank in NITROFATDIR when it is used #78

AntonioND opened this issue Jun 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AntonioND
Copy link
Member

Right now the soundbank is always saved in the build directory, but the Makefile should detect if NITROFATDIR is used and place the soundbank there instead.

@AntonioND AntonioND added the bug Something isn't working label Jun 3, 2023
@AntonioND AntonioND self-assigned this Jul 21, 2023
@AntonioND
Copy link
Member Author

This is the first part of the work: fef7a59

@AntonioND AntonioND added this to the v1.0 milestone Nov 22, 2023
@AntonioND
Copy link
Member Author

It isn't possible to implement this in the build system of the ARM7+ARM9 combined template, so I'm closing this issue.

The soundbank needs to be built before the ARM9 is built so that the soundbank header can be included by ARM9 source code files. This means that the ARM9 should have the soundbank generation rule.

However, the global makefile also needs to have the rule because the final NDS file depends on the soundbank (it is included in the nitroFS filesystem).

devkitARM makefiles don't support this scenario either (for the same reasons I've just mentioned).

I've created https://github.com/AntonioND/architectds to support this kind of situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant