Add support to browser for gaiahub and keyfiles #833

kantai · 2017-09-28T14:16:42Z

Okay -- here's some instructions for getting this running with blockstack-core, browser, and blockstack todos using docker containers:

Get these repos:

git clone https://github.com/blockstack/blockstack-browser -b feature/multi-reader-storage
git clone https://github.com/blockstack/blockstack-core -b feature/multi-reader-storage
git clone https://github.com/kantai/blockstack-todos -b feature/multi-reader-storage

Now -- build your containers:

cd blockstack-browser && docker build . -f Dockerfile.keyfile.sources --tag browser:multi-reader-storage
cd ../blockstack-core && docker build . -f integration_tests/deployment/docker/Dockerfile.tests --tag blockstack-core:multi-reader-storage
cd ../blockstack-todos && docker build . --tag todos:multi-reader-storage

Now, run your containers:

docker run -dt --name blockstack-core-multi-reader -p 6270:6270 -e BLOCKSTACK_TEST_CLIENT_RPC_PORT=6270 -e BLOCKSTACK_TEST_CLIENT_BIND=0.0.0.0 blockstack-core:multi-reader-storage blockstack-test-scenario --interactive 2 blockstack_integration_tests.scenarios.portal_test_env
docker run -d --name blockstack-todos-multi-reader -p 5000:5000 -e BSK_TODOS_PORT=5000 -e BSK_TODOS_BINDADDR=0.0.0.0 todos:multi-reader-storage npm run start
docker run -d --name blockstack-browser-multi-reader -p 8888:8888 browser:keyfile blockstack-browser
docker run -d --name blockstack-cors-multi-reader -e CORSPROXY_HOST="0.0.0.0" -p 1337:1337 browser:multi-reader-storage blockstack-cors-proxy

Open your browser to localhost:8888, make a profile, etc. and use blockstack-todos from localhost:5000

This works for me in regtest (and mainnet without a username) -- would be good to get other people testing this out as well.

See (now closed) PRs #739 #808

…JSON string or a JWT. Handle both cases.

…d signing key, which will be used to generate key files for profiles.

…profile with a keyfile instead.

…rofile's keyfile)

…red in the keyfile

…der datastore for the application for the given account, and (2) will re-generate the account's profile to add/update the key file with the datastore's routing information.

…r has a blockchain ID, create a multi-reader datastore and update the user's profile's keyfile with the datastore's routing information. Upload the profile to the user's storage providers, and update the locally-cached profile state to reflect the newly-created profile.

…irectly into my javascript, it may blind.

…r than a random one

…-connected checks

…p local node_modules out of the picture

…owser into feature/keyfile

…nto feature/keyfile+gaiahub

…locktack.js + fix dockerfile and add support to select gaiahub as an allowed driver

CLAassistant · 2017-09-28T14:16:48Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kantai
✅ jcnelson
❌ larrysalibra
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

larrysalibra

Awesome work! I made a few style comments. Given our tight timeline, I think we can get way with leaving the asserts for the moment - I'll open an issue to clean them up in the future. I'll clean up the lint during my testing. Thanks for all of your hard work on this @jcnelson @kantai and @jackzampolin !

larrysalibra · 2017-09-28T14:23:15Z

app/js/utils/api-utils.js

 import { signProfileForUpload } from './index'

+import { keyFileCreate, keyFileParse, keyFileProfileSerialize, keyFileUpdateApps, keyFileMakeDelegationPrivateKeys, keyFileICANNToAppName, getPubkeyHex, datastoreMountOrCreate } from 'blockstack'
+const jsontokens = require('jsontokens')
+const assert = require('assert')


the assert package is for unit testing and isn't intended to be used in shipped code: see https://www.npmjs.com/package/assert

larrysalibra · 2017-09-28T14:23:47Z

app/js/utils/api-utils.js

@@ -143,15 +146,20 @@ function profileInsertStorageRoutingInfo(profile, driverName, indexUrl) {
 export function setCoreStorageConfig(api,
  blockchainId = null, profile = null, profileSigningKeypair = null) {
  return new Promise((resolve, reject) => {
+    var driverName = null;


There's a lot of lint here. can we clean this up?

I'll clean it up during testing.

larrysalibra · 2017-09-28T14:33:39Z

app/js/utils/api-utils.js

+
+      assert(deviceId, 'Invalid session: missing device ID')
+      assert(appName, 'Invalid session: missing application name')
+      assert(datastoreId, 'Invalid session: missing datastore ID')


A better way to handle this than using assert is to check for the value and if it is missing, log a useful error message and reject() the promise.

larrysalibra · 2017-09-28T14:36:31Z

app/js/App.js

-      accountCreated: !!this.props.encryptedBackupPhrase,
-      storageConnected: !!this.props.dropboxAccessToken,
-      coreConnected: !!this.props.api.coreAPIPassword,
+      accountCreated: this.props.encryptedBackupPhrase ? true : false,


These changes introduce lint and break the automated test suite. (npm run test tests for lint in files that were previously verified as lint-free)

kantai · 2017-09-28T14:42:40Z

I made a few style comments.

Thanks! I'll be sure my javascript lints okay in the future.

jackzampolin · 2017-09-28T15:06:08Z

I have this is working for both no username and for users with names.

larrysalibra · 2017-10-20T18:34:23Z

Moving this to backlog - it's on hold for a while.

larrysalibra · 2017-12-15T00:11:42Z

@kantai I'm going to close this pull request since we're going with the apps write directly to gaia hubs and light weight multi-reader storage approaches. If it should stay open, please re-open!

jcnelson and others added 30 commits September 10, 2017 17:56

When resolving a zone file to a profile, the profile can either be a …

0c42553

…JSON string or a JWT. Handle both cases.

update deriveIdentityKeypair() to include the (base58-encoded) key an…

51cbcd8

…d signing key, which will be used to generate key files for profiles.

When signing a profile for upload while registering a name, create a …

563fa70

…profile with a keyfile instead.

registerName() now takes the key index (which will be stored to the p…

f4f8bad

…rofile's keyfile)

when registering a name, include the identity address index to be sto…

857ad0e

…red in the keyfile

add a method setupAppDatastore(), which will (1) create a multi-rea…

6c9557c

…der datastore for the application for the given account, and (2) will re-generate the account's profile to add/update the key file with the datastore's routing information.

require blockstack-storage 0.3.0

e7e4d5e

no longer need a blockchain ID to create a keyfile

9d9aa87

hack-y beginnings of prototype integration of gaia/hub. do not look d…

dc1b52e

…irectly into my javascript, it may blind.

now to authenticate with the gaia hub, it uses the identity key rathe…

f24c763

…r than a random one

profile and photo uploading working with the gaia-hub

c74cf22

Merge branch 'develop' into feature/storage-service-hacks

79119e6

add config setting for gaiaHubUrl

0ab360b

consistent naming of gaiahub functions

59d56e7

use api.storageConnected instead of dropboxAccessToken for storage-is…

54d8531

…-connected checks

Authentication headers should be Authorization headers for gaiaHub

9a3497f

Merge branch 'master' into feature/keyfile

5eb8f74

Merge branch 'develop' into feature/storage-service-hacks

569c9e1

forgot to commit conflict resolutions :-/

a6acd50

Dockerfile to build keyfile js, plus including a .dockerignore to kee…

6d9d10b

…p local node_modules out of the picture

blockstack-storage-js -> aaron's fork

e19f130

revert Dockerfile + add a keyfile specific one

4b68914

revert Dockerfile + add a keyfile specific one

f8f1a60

Merge branch 'feature/keyfile' of github.com:blockstack/blockstack-br…

234b98c

…owser into feature/keyfile

Merge branch 'develop' into feature/keyfile

cecaa04

kantai/blockstack-storage-js -> blockstack/blockstack-storage-js

375a1b6

fixes weirdness with the docker filesystem operations

ef6f742

Merge remote-tracking branch 'origin/feature/storage-service-hacks' i…

0e3c21e

…nto feature/keyfile+gaiahub

remove package-lock and update package.json to allow install of new b…

b4aaa40

…locktack.js + fix dockerfile and add support to select gaiahub as an allowed driver

kantai added 3 commits September 27, 2017 12:26

add versioning to dockerfile git clones

1593fc8

always call create data store, even if you don't have a username

8ca9056

flipping boolean typo

e313e24

kantai added the feature label Sep 28, 2017

This was referenced Sep 28, 2017

Feature/keyfile #739

Closed

Add gaia hub support to browser #808

Closed

larrysalibra reviewed Sep 28, 2017

View reviewed changes

larrysalibra mentioned this pull request Sep 28, 2017

Story: multi-reader storage #752

Closed

larrysalibra added the backlog label Oct 20, 2017

larrysalibra closed this Dec 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to browser for gaiahub and keyfiles #833

Add support to browser for gaiahub and keyfiles #833

kantai commented Sep 28, 2017 •

edited

CLAassistant commented Sep 28, 2017 •

edited

larrysalibra left a comment

larrysalibra Sep 28, 2017

larrysalibra Sep 28, 2017

larrysalibra Sep 28, 2017

larrysalibra Sep 28, 2017

larrysalibra Sep 28, 2017

kantai commented Sep 28, 2017 •

edited

jackzampolin commented Sep 28, 2017

larrysalibra commented Oct 20, 2017

larrysalibra commented Dec 15, 2017 •

edited

Add support to browser for gaiahub and keyfiles #833

Add support to browser for gaiahub and keyfiles #833

Conversation

kantai commented Sep 28, 2017 • edited

CLAassistant commented Sep 28, 2017 • edited

larrysalibra left a comment

Choose a reason for hiding this comment

larrysalibra Sep 28, 2017

Choose a reason for hiding this comment

larrysalibra Sep 28, 2017

Choose a reason for hiding this comment

larrysalibra Sep 28, 2017

Choose a reason for hiding this comment

larrysalibra Sep 28, 2017

Choose a reason for hiding this comment

larrysalibra Sep 28, 2017

Choose a reason for hiding this comment

kantai commented Sep 28, 2017 • edited

jackzampolin commented Sep 28, 2017

larrysalibra commented Oct 20, 2017

larrysalibra commented Dec 15, 2017 • edited

kantai commented Sep 28, 2017 •

edited

CLAassistant commented Sep 28, 2017 •

edited

kantai commented Sep 28, 2017 •

edited

larrysalibra commented Dec 15, 2017 •

edited