Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price lookup with invalid characters returns unclear error #464

Closed
larrysalibra opened this issue Jun 23, 2017 · 3 comments
Closed

Price lookup with invalid characters returns unclear error #464

larrysalibra opened this issue Jun 23, 2017 · 3 comments
Labels
bug Unwanted or unintended property causing functional harm

Comments

@larrysalibra
Copy link
Contributor

A user tried blockstack price test123*.id and got a response that doesn't make sense. I'd expect to be told that the name I'm trying is invalid or something to that effect.

This is related to #422 and I suggest we fix it along with improved error responses across the board.

The bug report and output can be found in this forum post: https://forum.blockstack.org/t/special-characters-alphanumeric/1212?u=larry

@larrysalibra larrysalibra added the bug Unwanted or unintended property causing functional harm label Jun 23, 2017
@kantai
Copy link
Member

kantai commented Jun 23, 2017

Actually, the error outputted there was due to a bug in rc-0.14.2 at the time, which has since been fixed.

Now -- if you use the command line:

$ blockstack price test123*.id
{
    "error": "Neither a valid name or namespace:\n   * The name specified is invalid. Names may only contain lowercase alphanumeric characters and underscores.\n   * The namespace specified is invalid.  Namespace IDs cannot have \".\" or \"+\" in them."
}

@kantai
Copy link
Member

kantai commented Jun 23, 2017

Anyways, since this error output is now okay, I'm closing this issue. The issue with errors in general is still open (and a bigger task overall).

@kantai kantai closed this as completed Jun 23, 2017
@larrysalibra
Copy link
Contributor Author

Thank you @kantai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted or unintended property causing functional harm
Projects
None yet
Development

No branches or pull requests

2 participants