Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM: Replace Environment::caller and Environment::sender with Option<Value::Principal(..)> #1812

Closed
jcnelson opened this issue Aug 14, 2020 · 3 comments
Closed

VM: Replace Environment::caller and Environment::sender with Option<Value::Principal(..)> #1812

jcnelson opened this issue Aug 14, 2020 · 3 comments
Labels
good first issue Appropriate for a new open source contribution. refactoring stale
Projects
Krypton: Stacks 2.0 Testnet Phase 3

Comments

@jcnelson
Copy link
Member

The caller and sender fields in vm::context::Environment are always principal types if they're not None. Creating this as an issue because changing this potentially an invasive refactoring procedure.
@jcnelson jcnelson added the good first issue Appropriate for a new open source contribution. label Aug 14, 2020
@jcnelson jcnelson mentioned this issue Mar 10, 2021
Closed
@pavitthrap pavitthrap self-assigned this Mar 10, 2021
@pavitthrap pavitthrap mentioned this issue Mar 11, 2021
Merged
4 tasks
@stale
Copy link

stale bot commented Sep 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 7, 2021
@pavitthrap pavitthrap removed their assignment Sep 24, 2021
@stale stale bot removed the stale label Sep 24, 2021
@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically closed. Please reopen if needed.

@stale stale bot closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Appropriate for a new open source contribution. refactoring stale
Projects
No open projects
Krypton: Stacks 2.0 Testnet Phase 3
  
New Issues
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcnelson @pavitthrap