Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove byteorder dependency #1737

Merged
merged 1 commit into from Jul 14, 2020
Merged

Remove byteorder dependency #1737

merged 1 commit into from Jul 14, 2020

Conversation

kantai
Copy link
Member

@kantai kantai commented Jul 13, 2020

This removes the byteorder dependency (see #1717)

jcnelson
jcnelson approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kantai!

@kantai
Copy link
Member Author

kantai commented Jul 14, 2020

Going ahead and merging, since this is a small enough change that it doesn't seem necessary to get the second review.

@kantai kantai merged commit 6156c3c into master Jul 14, 2020
@kantai kantai deleted the feat/remove-byteorder branch July 14, 2020 16:23
@kantai kantai mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcnelson jcnelson jcnelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kantai @jcnelson