fix(Clarity2):Factor out 'stx-transfer-memo' into a separate function

[gregorycoppola]

Fixes #2615

Motivation

Currently, in the next branch, it is possible to supply a memo to stx-transfer?. However, it has been decided that it might be better to force the user to use a different function,stx-transfer-memo? if they are going to add a memo. The reason for this is to allow better type checking -- the user will either have to add a memo or not, depending on which version of the function they use, and they won't be able to forget to put a memo if they are using the "memo" version.

We also version-guard this function, so that one has to be using Stacks 2.1 in order to use it.

Testing

Tested using unit tests. The following tests have been modified:

M	src/vm/analysis/arithmetic_checker/tests.rs
M	src/vm/analysis/type_checker/tests/mod.rs
M	src/vm/tests/costs.rs
M	src/vm/tests/events.rs
M	src/vm/tests/simple_apply_eval.rs

[kantai]

LGTM! Just commented about a small test addition.

[gregorycoppola]

thanks for review!

[jcnelson]

I didn't see any gating for stx-transfer-memo?. I think you'll want to add that in first before merging -- stx-transfer-memo? is not valid in Clarity 1.

[gregorycoppola]

@jcnelson thanks for the comments.

I rebased against 'next' so now this PR has version guarding.

Refactored tests in src/vm/analysis/arithmetic_checker/tests.rs test the version guarding.

[jcnelson]

LGTM now. Thanks @gregorycoppola!

[gregorycoppola]

Thanks for the reviews everyone.