Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

feat: add validate address helper #102

Merged
merged 1 commit into from Jul 15, 2020

Conversation

kyranjamie
Copy link
Contributor

This helper function's repeated over a few repos. I figure this library's the most appropriate place to put it.

@project-bot project-bot bot added this to New issues in Splat Team Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   84.01%   84.07%   +0.05%     
==========================================
  Files          28       28              
  Lines        1802     1808       +6     
  Branches      367      367              
==========================================
+ Hits         1514     1520       +6     
  Misses        286      286              
  Partials        2        2              
Impacted Files Coverage Δ
src/utils.ts 78.48% <100.00%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0ad72...dca30ff. Read the comment docs.

@agraebe agraebe removed this from New issues in Splat Team Jul 7, 2020
Copy link
Contributor

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but wondering if you could do a bit more by adding an isValid32Address function to the c32check lib? This avoids the relatively expensive process from a throw/try/catch. It's a bit of a micro-optimization but could see it as a useful ddos prevention measure for certain projects.

@kyranjamie kyranjamie merged commit 9981f63 into master Jul 15, 2020
@kyranjamie kyranjamie deleted the feat/add-validate-address-helper branch July 15, 2020 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants