Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapper use of ReactQuery #1771

Closed
9 tasks done
kyranjamie opened this issue Oct 5, 2021 · 0 comments · Fixed by #2589
Closed
9 tasks done

Remove wrapper use of ReactQuery #1771

kyranjamie opened this issue Oct 5, 2021 · 0 comments · Fixed by #2589
Assignees
Labels
needs:refactoring Tech debt, developer experience, testing, etc.

Comments

@kyranjamie
Copy link
Collaborator

kyranjamie commented Oct 5, 2021

As discussed, our preference is to make use of React Query directly, rather using it via a wrapper library specific to Jotai.

Results in

  • Being less tied to a state management library
  • Having a simpler state set up, with fewer atom chains
  • Fewer protocol-level side effects being triggered implicitly

To the greatest extent possible, we should try and remove as many atoms as possible. Using the newly-created hooks to pass API data into components that need it, and thus removing the chained atom dependencies.

Query atoms

When picking one of these, create an issue for it so we can track them individually.

@kyranjamie kyranjamie added the needs:refactoring Tech debt, developer experience, testing, etc. label Oct 5, 2021
@kyranjamie kyranjamie added this to the Resolve technical debt milestone Oct 5, 2021
@markmhendrickson markmhendrickson linked a pull request Aug 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:refactoring Tech debt, developer experience, testing, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants