Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show receipt activity item for send-many events instead of fees #776

Closed
friedger opened this issue Apr 27, 2021 · 3 comments · Fixed by #828
Closed

Show receipt activity item for send-many events instead of fees #776

friedger opened this issue Apr 27, 2021 · 3 comments · Fixed by #828
Assignees
@Eshwari007
Labels
Enhancement 💡 Functionality needed or wanted by users

Comments

@friedger
Copy link
Contributor

This feature request is about the display of fees for contract call transactions in the list of transactions.

Currently, the wallet shows the fees that the tx sender paid even thought the users didn't send the tx. It is shown in the same column as the users stx movements, the amounts shown won't add up to the total balance.

The fees should be hidden if not paid by the user or shown differently. If paid by the user it should also shown the total transfer. Related to hirosystems/explorer#373
@markmhendrickson
Copy link
Collaborator

This is a screenshot of the current behavior:

image

This shows the amount of fees paid on top ("Contract call"), which should be replaced with an activity item showing the amount of STX received.

We can fix it using the API support provided by hirosystems/stacks-blockchain-api#547

@markmhendrickson markmhendrickson added the Enhancement 💡 Functionality needed or wanted by users label Apr 27, 2021
@markmhendrickson markmhendrickson changed the title Do not show contract call fees Show receipt activity item for send-many events instead of fees Apr 27, 2021
@kyranjamie
Copy link
Collaborator

Reddit users expressing confusion, definitely needs to be addressed

https://www.reddit.com/r/stacks/comments/n9aq2b/i_read_on_my_stacks_wallet_that_there_has_been_a/
https://www.reddit.com/r/stacks/comments/n92k3o/shouldnt_i_be_seeing_my_rewards_in_my_wallet/

@kyranjamie kyranjamie self-assigned this Jun 1, 2021
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
baa2999
@kyranjamie kyranjamie mentioned this issue Jun 1, 2021
Merged
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
b6386a2
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
7d9997a
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
b4948a4
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
fc63cda
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
35ca558
kyranjamie added a commit that referenced this issue Jun 1, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
a72fd07
kyranjamie added a commit that referenced this issue Jun 4, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
15c1bad
@Eshwari007
Copy link

@kyranjamie Can I we sync up on the ticket in order to get more content of the issue?Thx in ad

kyranjamie added a commit that referenced this issue Jun 18, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
8cc850f
kyranjamie added a commit that referenced this issue Jun 22, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
073c41a
kyranjamie added a commit that referenced this issue Jun 22, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
00aaa9c
kyranjamie added a commit that referenced this issue Jun 22, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
121a2d0
kyranjamie added a commit that referenced this issue Jun 23, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
0d140c0
kyranjamie added a commit that referenced this issue Jun 24, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
0f504f8
kyranjamie added a commit that referenced this issue Jun 24, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
3197ca4
blockstack-devops pushed a commit that referenced this issue Jun 24, 2021
@semantic-release-bot
chore(release): 4.3.1
e0aded9 
## [4.3.1](v4.3.0...v4.3.1) (2021-06-24)

### Bug Fixes

* add memo not needed warning, closes [#571](#571) ([9da0ed5](9da0ed5))
* display send-many tx amounts accurately, closes [#776](#776) ([3197ca4](3197ca4))
* display send-many tx amounts accurately, closes [#776](#776) ([073c41a](073c41a))
kyranjamie added a commit that referenced this issue Jun 24, 2021
@kyranjamie
fix: display send-many tx amounts accurately, closes #776
c649ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eshwari007 Eshwari007

Labels
Enhancement 💡 Functionality needed or wanted by users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: display send-many tx amounts accurately leather-wallet/desktop
4 participants
@markmhendrickson @friedger @kyranjamie @Eshwari007