Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app] Profile might be reset #322

Closed
friedger opened this issue Apr 8, 2020 · 2 comments
Closed

[app] Profile might be reset #322

friedger opened this issue Apr 8, 2020 · 2 comments
Assignees
@timstackblock
Labels
bug Functionality broken

Comments

@friedger
Copy link
Contributor

friedger commented Apr 8, 2020

Under certain conditions the profile is reset

https://github.com/blockstack/ux/blob/69d03ee4c7c535981ddf49493984d21014603f33/packages/keychain/src/identity.ts#L53

This could happen for apps with permission publish_data and if fetching the profile fails
@friedger friedger mentioned this issue Apr 8, 2020
Closed
@markmhendrickson markmhendrickson added the bug Functionality broken label Apr 16, 2020
@hstove
Copy link
Contributor

hstove commented Apr 17, 2020

Thanks @friedger, this is a good point. I don't have a fix yet but we're looking into it.

hstove added a commit that referenced this issue Apr 27, 2020
@hstove
fix: safer logic when fetching profiles, #322
bd9a0b5
@hstove hstove assigned timstackblock and unassigned hstove Apr 27, 2020
hstove added a commit that referenced this issue Apr 30, 2020
@hstove
fix: safer logic when fetching profiles, #322
e0a67fd
@hstove
Copy link
Contributor

hstove commented May 13, 2020

Fixed in the above commits, good catch Friedger 👍

@hstove hstove closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timstackblock timstackblock

Labels
bug Functionality broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markmhendrickson @hstove @friedger @timstackblock