Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some nits #757

Closed
aulneau opened this issue Jan 10, 2021 · 3 comments
Closed

Some nits #757

aulneau opened this issue Jan 10, 2021 · 3 comments
Assignees

Comments

@aulneau
Copy link
Contributor

aulneau commented Jan 10, 2021

Some text/inputs aren't respecting the color mode of the app:

Screen Shot 2021-01-10 at 2 14 24 PM

Action not attached to bottom. Seems like there is too much space below it
Screen Shot 2021-01-10 at 3 15 12 PM

Scroll bar seems to be enabled on the bottom drawer. No "X" icon to close (I know you can hit the backdrop, but folks might not intuit that).
Screen Shot 2021-01-10 at 3 15 47 PM

On account switch screen, it overflows horizontally due to address + check icon
Screen Shot 2021-01-10 at 3 16 59 PM

I really wish I knew which account I was on in this view:
Screen Shot 2021-01-10 at 3 20 32 PM

Code bg is not dark:
Screen Shot 2021-01-10 at 3 21 05 PM

@hstove
Copy link
Contributor

hstove commented Feb 3, 2021

@markmhx @andresgalante can we break this up into smaller issues? I think the only remaining issue is around the scrollbar. Not sure if that needs to block the audit, though.

@markmhendrickson
Copy link
Collaborator

Is this the issue you mean in regards to the scrollbar?

image

If so, please create a separate issue for that and assign yourself. Then move this issue into QA and assign to Tim. He can then test all but the scrollbar-related one.

Let's make sure to add separate issues from the start for this sort of feedback going forward.

@markmhendrickson
Copy link
Collaborator

On second thought, let's hold off assigning for QA in general since we'll be focusing on this issue's milestone in a future sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants