Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPV: Timeout Stops Syncing over Tor #43

Open
JeffVandrewJr opened this issue May 9, 2019 · 2 comments
Open

SPV: Timeout Stops Syncing over Tor #43

JeffVandrewJr opened this issue May 9, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@JeffVandrewJr
Copy link

JeffVandrewJr commented May 9, 2019

Description

When using the trusted peer for SPV over Tor, the timeout feature automatically logs the user out, which seems to stop the SPV syncing process. It's hard to 100% tell because reopening the app to look at the SPV block notifications causes a new login which restarts the peer connection and the progress bar resets. The notification bar still shows syncing at that point, but it doesn't seem to progress. Upon re logging in, it has to reconnect to the peer over again before picking up where it left off.

UPDATE: It's really just a UX thing with the progress bar resetting rather than it actually stopping syncing. See the next comment in the thread.

Since the SPV syncing takes a while, it would be good if it could continue in the background rather than requiring the user to log back in every 10 mins.

Version

3.1.3

Steps to reproduce

When using the trusted peer for SPV over Tor, the timeout feature automatically logs the user out, which seems to stop the SPV syncing process. It's hard to 100% tell because reopening the app to look at the SPV block notifications causes a new login which restarts the peer connection and the progress bar resets. The notification bar still shows syncing at that point, but it doesn't seem to progress. Upon re logging in, it has to reconnect to the peer over again before picking up where it left off.

Expected behaviour

Continued background sync on logout, especially for the initial sync.

Actual behaviour

Timeout kills the sync. See the next comment in the thread.

Screenshots

N/A

Device or machine

Xiaomi Mi Mix 2, Android 8.0.0 OPR1.70623.027, MIUI Global 10.2

Additional info

None

@JeffVandrewJr JeffVandrewJr changed the title SPV: Timeout Stops Syncing SPV: Timeout Stops Syncing over Tor May 9, 2019
@JeffVandrewJr
Copy link
Author

JeffVandrewJr commented May 9, 2019

Update: It actually does keep syncing after the timeout and eventually finishes; this is really just a UX problem, as the connection to the trusted peer is reset and the progress bar resets to the beginning every time the app is launched.

@domegabri domegabri added the enhancement Request to improve existing features, UI or UX label Aug 2, 2019
@domegabri
Copy link
Contributor

@JeffVandrewJr thank you for reporting! Yes this is a UX bug, the progress bar is not really representative of the work left but it restarts every time. The app actually picks up from where it left during the background spv syncing.

@domegabri domegabri added bug Something isn't working and removed enhancement Request to improve existing features, UI or UX labels Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants