Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

[marketmaker] possible to configure tpu retransmissions (max retries in txn opts) when sending a transaction #44

Merged

Conversation

ochaloup
Copy link
Contributor

There is a missing way to configure the max retries on sending transaction to RPC node. The attempt of this PR is to fix this deficiency.
What do you think @OpinionatedGeek ?

@OpinionatedGeek
Copy link
Contributor

I like it a lot - thanks for doing this!

One thing though. The client already retries sending to the RPC node in some circumstances, so I worry 'max retries' might not be clear that this setting governs the number of retry attempts the RPC server will make when sending it to the validator, not the number of retry attempts when sending to the RPC server.

Can you think of a better name for it? All my attempts turn out long and unwieldy.

@ochaloup
Copy link
Contributor Author

@OpinionatedGeek I see, I can try, just you know the naming is the one of the hardest issue in the computer engineering :-)
I can think of like tpu_retransmissions or tpu_retries. Would that makes sense?

@OpinionatedGeek
Copy link
Contributor

tpu_retransmissions sounds excellent - really makes it clear to me what it sets. Many thanks for this!

@ochaloup ochaloup changed the title [marketmaker] possible to configure max retries when sending transaction [marketmaker] possible to configure tpu retransmissions (max retries in txn opts) when sending a transaction Feb 14, 2022
@ochaloup
Copy link
Contributor Author

@OpinionatedGeek great, thank you.
I renamed the max retries to tpu retransmissions (plus added an update on missing building calls at context builder in respect of transaction_status_collector).
Please, take a look. Thanks!

@OpinionatedGeek OpinionatedGeek merged commit fa21fff into blockworks-foundation:main Feb 15, 2022
@OpinionatedGeek
Copy link
Contributor

Brilliant - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants