Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Suggestion #40

Closed
ShahzadUmarBaig opened this issue Oct 24, 2020 · 1 comment · Fixed by #41
Closed

Changes Suggestion #40

ShahzadUmarBaig opened this issue Oct 24, 2020 · 1 comment · Fixed by #41

Comments

@ShahzadUmarBaig
Copy link
Contributor

ShahzadUmarBaig commented Oct 24, 2020

I have made a few changes in my fork, first I have changed the mood sheet text size back to default, it is extra big making it a little bolder, additionally I have changed the way circle colors are created, they are created using borderRadius previously where as I am using BoxShape.Circle which makes it perfectly circle without any radius, secondly I have change the padding to 8,8 that makes the circle smaller let me attach a screen shot, and finally I was able to fix the Activity edit sheet mood theme that is mentioned on the board, I have changed the container from ActionContainer to ColorContainer where the starting color is grey and once the user selects the color it returns back the selected color.

@hashirshoaeb
Copy link
Collaborator

Hi, that sounds good. Create a pull request. Let me see your changes.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants