Outdated rules

[akira02]

Readme

Should be "extends": "@portto/eslint-config-portto/browser".
Also need following package installed. Is it necessary?

yarn add --dev eslint-plugin-compat eslint-plugin-flowtype

rules/base.js

• semi: ['error', 'always']
  Do we need semi every line?
• 'no-nested-ternary': 'error'
  With prettier, nesting ternary expressions is acceptable now. And it will be more complicated in jsx if prohibited.

For example:

{status === ItemStatus.BUYING ? (
    <Spinner />
) : locked ? 
    'OUT OF STOCK'
  : 
    'BUY'
}

rules/react.js

• 'react/react-in-jsx-scope': 'error'
  After React v17 this is no longer needed.
• 'react/jsx-filename-extension': ['error', { extensions: ['.js'] }],
  We alse use TypeScripts now.

rules/import.js

• import/extensions missing .ts and .tsx

Other

Overall, TypeScript and ES6 is not support well. Maybe define a new eslint rule well be better?