Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty space exists #12

Closed
arkenous opened this issue May 31, 2016 · 6 comments
Closed

Empty space exists #12

arkenous opened this issue May 31, 2016 · 6 comments
Assignees
Labels

Comments

@arkenous
Copy link

GitHub update interface of the contributions calendar on May 20, 2016. As part of this update, code streaks are no longer featured on the contributions calendar.
https://github.com/blog/2173-more-contributions-on-your-profile

But some codes related to code streaks are still existing in this project. Due to this, empty space is shown.

github-calendar_screenshot

OS: OSX El Capitan 10.11.5, Browser: Safari 9.1.1

@IonicaBizau
Copy link
Member

Obviously yes. I'm not sure which would be the best here: should we compute the longest streak, total contributions and current streak like before? It's actually possible and not that hard.

The simple way is just to update the min-height value.

@IonicaBizau
Copy link
Member

What do you think? Maybe having an option to enable/disable the global stats (total, longest and current streaks) would not be bad. 💭

@arkenous
Copy link
Author

I think that having an option to enable/disable the global stats is best to resolve this issue.

But I'm sorry I don't know how to compute global stats.😢

@IonicaBizau
Copy link
Member

I have a module to parse the HTML: https://github.com/IonicaBizau/github-calendar-parser
From git-stats I'm going to split another module which will compute the stats: because it's the same code.

🚀

@IonicaBizau
Copy link
Member

@trileg Actually, that module parses the total, longest and current streak, already ✨

@IonicaBizau IonicaBizau self-assigned this Jun 1, 2016
@IonicaBizau
Copy link
Member

🚢 1.1.x 🎉 Fixed via #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants